Issue 10867093: Add linux_chromeos to default tryjob.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10867093: Add linux_chromeos to default tryjob. (Closed)

Created:
8 years, 3 months ago by jam

Modified:
8 years, 3 months ago

Reviewers:
cmp, Peter Mayo

CC:
chromium-reviews

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Add linux_chromeos to default tryjob. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=153751

Patch Set 1 #

Total comments: 1

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	PRESUBMIT.py	View		1 chunk	+1 line, -1 line	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Peter Mayo

8 years, 3 months ago (2012-08-29 10:19:47 UTC) #3

Non-scoring

http://codereview.chromium.org/10867093/diff/1/PRESUBMIT.py
File PRESUBMIT.py (right):

http://codereview.chromium.org/10867093/diff/1/PRESUBMIT.py#newcode590
PRESUBMIT.py:590: 'linux_chromeos', 'android']
Please add a TODO to remove the subsequent additions of linux_chromeos if this
sticks.  In particular, there are PRESUBMITS in other directories IIRC, and
there are tests below here.

Also check that duplicating the name in the list doesn't cause extra try-jobs. 
I think they don't, but I don't trust my memory that far.

Expand Messages | Collapse Messages