Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 10867091: [net] Re-enable async DNS field trial (on canary only) (Closed)

Created:
8 years, 3 months ago by szym
Modified:
8 years, 3 months ago
Reviewers:
cbentzel
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

[net] Re-enable async DNS field trial (on canary only) BUG=143454 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=153550

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M chrome/browser/net/async_dns_field_trial.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
szym
I will land this after TPM okays this.
8 years, 3 months ago (2012-08-27 20:52:46 UTC) #1
cbentzel
8 years, 3 months ago (2012-08-27 21:01:28 UTC) #2
LGTM

On Mon, Aug 27, 2012 at 4:52 PM, <szym@chromium.org> wrote:

> Reviewers: cbentzel,
>
> Message:
> I will land this after TPM okays this.
>
> Description:
> [net] Re-enable async DNS field trial (on canary only)
>
> BUG=143454
>
>
> Please review this at
http://codereview.chromium.**org/10867091/<http://codereview.chromium.org/108...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files:
>   M chrome/browser/net/async_dns_**field_trial.cc
>
>
> Index: chrome/browser/net/async_dns_**field_trial.cc
> diff --git a/chrome/browser/net/async_**dns_field_trial.cc
> b/chrome/browser/net/async_**dns_field_trial.cc
> index b37028c905fe4c12ec5673cb8b6069**f519d6c3c3..**
> 215ffdcf3a147b1c862b33aacffabe**1b435c4876 100644
> --- a/chrome/browser/net/async_**dns_field_trial.cc
> +++ b/chrome/browser/net/async_**dns_field_trial.cc
> @@ -18,9 +18,9 @@ bool ConfigureAsyncDnsFieldTrial() {
>    const base::FieldTrial::Probability kAsyncDnsDivisor = 100;
>    base::FieldTrial::Probability enabled_probability = 0;
>
> -  // TODO(szym): bring the probability up after fixing
> http://crbug.com/121085
> -  if (chrome::VersionInfo::**GetChannel() <=
> chrome::VersionInfo::CHANNEL_**DEV)
> -    enabled_probability = 0;
> +  // TODO(szym): expand to DEV channel after fixing
> http://crbug.com/121085
> +  if (chrome::VersionInfo::**GetChannel() <=
> chrome::VersionInfo::CHANNEL_**CANARY)
> +    enabled_probability = 50;
>
>    scoped_refptr<base::**FieldTrial> trial(
>        base::FieldTrialList::**FactoryGetFieldTrial(
>
>
>

Powered by Google App Engine
This is Rietveld 408576698