Implement array bounds checks explicitly in the optimized IL.

runtime/vm/intermediate_language_ia32.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/globals.h"  // Needed here to get TARGET_ARCH_IA32.
 #if defined(TARGET_ARCH_IA32)
 
 #include "vm/intermediate_language.h"
 
 #include "lib/error.h"
@@ skipping 794 matching lines @@
   locs->set_out(Location::RequiresRegister());
   return locs;
 }
 
 
 void LoadIndexedComp::EmitNativeCode(FlowGraphCompiler* compiler) {
   Register receiver = locs()->in(0).reg();
   Register index = locs()->in(1).reg();
   Register result = locs()->out().reg();
 
-  const DeoptReasonId deopt_reason =
-      (receiver_type() == kGrowableObjectArrayCid) ?
-      kDeoptLoadIndexedGrowableArray : kDeoptLoadIndexedFixedArray;
-
-  Label* deopt = compiler->AddDeoptStub(original()->deopt_id(),
-                                        original()->try_index(),
-                                        deopt_reason);
-
   switch (receiver_type()) {
     case kArrayCid:
     case kImmutableArrayCid:
-      __ cmpl(index, FieldAddress(receiver, Array::length_offset()));
-      __ j(ABOVE_EQUAL, deopt);
       // Note that index is Smi, i.e, times 2.
       ASSERT(kSmiTagShift == 1);
       __ movl(result, FieldAddress(receiver, index, TIMES_2, sizeof(RawArray)));
       break;
 
     case kGrowableObjectArrayCid: {
       Register temp = locs()->temp(0).reg();
-
-      __ cmpl(index,
-              FieldAddress(receiver, GrowableObjectArray::length_offset()));
-      __ j(ABOVE_EQUAL, deopt);
       __ movl(temp, FieldAddress(receiver, GrowableObjectArray::data_offset()));
       // Note that index is Smi, i.e, times 2.
       ASSERT(kSmiTagShift == 1);
       __ movl(result, FieldAddress(temp, index, TIMES_2, sizeof(RawArray)));
       break;
     }
 
     default:
       UNREACHABLE();
       break;
   }
 }
 
 
 LocationSummary* StoreIndexedComp::MakeLocationSummary() const {
   ASSERT((receiver_type() == kGrowableObjectArrayCid) ||
          (receiver_type() == kArrayCid));
   const intptr_t kNumInputs = 3;
   const intptr_t kNumTemps = receiver_type() == kGrowableObjectArrayCid ? 1 : 0;
   LocationSummary* locs =
       new LocationSummary(kNumInputs, kNumTemps, LocationSummary::kNoCall);
   locs->set_in(0, Location::RequiresRegister());
   locs->set_in(1, Location::RequiresRegister());
   locs->set_in(2, Location::RequiresRegister());
   if (receiver_type() == kGrowableObjectArrayCid) {
     locs->set_temp(0, Location::RequiresRegister());
   }
-  locs->set_out(Location::NoLocation());
   return locs;
 }
 
 
 void StoreIndexedComp::EmitNativeCode(FlowGraphCompiler* compiler) {
   Register receiver = locs()->in(0).reg();
   Register index = locs()->in(1).reg();
   Register value = locs()->in(2).reg();
 
-  Label* deopt = compiler->AddDeoptStub(original()->deopt_id(),
-                                        original()->try_index(),
-                                        kDeoptStoreIndexed);
-
   switch (receiver_type()) {
     case kArrayCid:
     case kImmutableArrayCid:
-      __ cmpl(index, FieldAddress(receiver, Array::length_offset()));
-      __ j(ABOVE_EQUAL, deopt);
       // Note that index is Smi, i.e, times 2.
       ASSERT(kSmiTagShift == 1);
       if (this->value()->NeedsStoreBuffer()) {
         __ StoreIntoObject(receiver,
             FieldAddress(receiver, index, TIMES_2, sizeof(RawArray)),
             value);
       } else {
         __ StoreIntoObjectNoBarrier(receiver,
             FieldAddress(receiver, index, TIMES_2, sizeof(RawArray)),
             value);
       }
       break;
 
     case kGrowableObjectArrayCid: {
       Register temp = locs()->temp(0).reg();
-      __ cmpl(index,
-              FieldAddress(receiver, GrowableObjectArray::length_offset()));
-      __ j(ABOVE_EQUAL, deopt);
       __ movl(temp, FieldAddress(receiver, GrowableObjectArray::data_offset()));
       // Note that index is Smi, i.e, times 2.
       ASSERT(kSmiTagShift == 1);
       if (this->value()->NeedsStoreBuffer()) {
         __ StoreIntoObject(temp,
             FieldAddress(temp, index, TIMES_2, sizeof(RawArray)),
             value);
       } else {
         __ StoreIntoObjectNoBarrier(temp,
             FieldAddress(temp, index, TIMES_2, sizeof(RawArray)),
@@ skipping 1449 matching lines @@
 void CheckSmiComp::EmitNativeCode(FlowGraphCompiler* compiler) {
   Register value = locs()->in(0).reg();
   Label* deopt = compiler->AddDeoptStub(deopt_id(),
                                         try_index(),
                                         kDeoptCheckSmi);
   __ testl(value, Immediate(kSmiTagMask));
   __ j(NOT_ZERO, deopt);
 }
 
 
+LocationSummary* CheckArrayBoundComp::MakeLocationSummary() const {
+  return LocationSummary::Make(2,
+                               Location::NoLocation(),
+                               LocationSummary::kNoCall);
+}
+
+
+void CheckArrayBoundComp::EmitNativeCode(FlowGraphCompiler* compiler) {
+  Register receiver = locs()->in(0).reg();
+  Register index = locs()->in(1).reg();
+
+  const DeoptReasonId deopt_reason =
+      (array_type() == kGrowableObjectArrayCid) ?
+      kDeoptLoadIndexedGrowableArray : kDeoptLoadIndexedFixedArray;
+  Label* deopt = compiler->AddDeoptStub(deopt_id(),
+                                        try_index(),
+                                        deopt_reason);
+  switch (array_type()) {
+    case kArrayCid:
+    case kImmutableArrayCid:
+      __ cmpl(index, FieldAddress(receiver, Array::length_offset()));
+      break;
+    case kGrowableObjectArrayCid:
+      __ cmpl(index,
+              FieldAddress(receiver, GrowableObjectArray::length_offset()));
+      break;
+  }
+  __ j(ABOVE_EQUAL, deopt);
+}
+
+
 }  // namespace dart
 
 #undef __
 
 #endif  // defined TARGET_ARCH_X64