Fix crash in DownloadsDOMHandler::GetDownloadByValue

Fix crash in DownloadsDOMHandler::GetDownloadByValue
BUG=144877
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=153511

[benjhayden, 2012-08-26 15:56:43]

PTAL

[Randy Smith (Not in Mondays), 2012-08-27 01:45:04]

LGTM.  

Doesn't have to be in this CL, but a test to catch this case wouldn't be a bad
idea.

[James Hawkins, 2012-08-27 13:33:06]

LGTM with optional nit.

https://chromiumcodereview.appspot.com/10867077/diff/1/chrome/browser/ui/webu...
File chrome/browser/ui/webui/downloads_dom_handler.cc (right):

https://chromiumcodereview.appspot.com/10867077/diff/1/chrome/browser/ui/webu...
chrome/browser/ui/webui/downloads_dom_handler.cc:518:
(original_profile_download_manager_ != NULL))
Optional nit: This is much shorter (and easier to read) as:

if (!download_item && original_profile_download_manager_)

[benjhayden, 2012-08-27 14:50:39]

Thanks!
I'll start writing the tests.

http://codereview.chromium.org/10867077/diff/1/chrome/browser/ui/webui/downlo...
File chrome/browser/ui/webui/downloads_dom_handler.cc (right):

http://codereview.chromium.org/10867077/diff/1/chrome/browser/ui/webui/downlo...
chrome/browser/ui/webui/downloads_dom_handler.cc:518:
(original_profile_download_manager_ != NULL))
On 2012/08/27 13:33:06, James Hawkins wrote:
> Optional nit: This is much shorter (and easier to read) as:
> 
> if (!download_item && original_profile_download_manager_)

Done.

[commit-bot: I haz the power, 2012-08-27 14:51:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/benjhayden@chromium.org/10867077/3002

[commit-bot: I haz the power, 2012-08-27 18:29:38]

Change committed as 153511