Issue 10867076: Enable gfx::Image to be created from empty platform images.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10867076: Enable gfx::Image to be created from empty platform images. (Closed)

Created:
8 years, 4 months ago by pkotwicz

Modified:
8 years, 3 months ago

Reviewers:
Robert Sesek

CC:
chromium-reviews, rsesek+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Enable gfx::Image to be created from empty platform images. BUG=142930 Test=ImageTest.EmptyImageFromEmptyPlatformImage Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=153525

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+48 lines, -18 lines)			Patch
	M	ui/gfx/image/image.cc	View	1 2 3 4	1 chunk	+26 lines, -18 lines	0 comments	Download
	M	ui/gfx/image/image_unittest.cc	View	1 2 3	1 chunk	+22 lines, -0 lines	0 comments	Download

Total messages: 4 (0 generated)

Robert Sesek

LGTM. Great. We've been wanting a CHECK() for isNull SkBitmap but couldn't make it happen. ...

8 years, 3 months ago (2012-08-27 16:02:43 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/10867076/10001

8 years, 3 months ago (2012-08-27 16:13:41 UTC) #3

Change committed as 153525