Try warnings as errors again, except on Official

Retry of warnings-as-errors for Windows third_party.

Same as patch here: https://chromiumcodereview.appspot.com/10827429/

except that warnings as errors is off if buildtype=Official. The previous CL
was OK everywhere that's visible on build.chromium.org including "Official"
but fails on internal builds.

R=thakis@chromium.org
BUG=126483, 140121, 143877
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=153278

[scottmg, 2012-08-24 18:44:30]

https://chromiumcodereview.appspot.com/10867058/diff/1/build/common.gypi
File build/common.gypi (right):

https://chromiumcodereview.appspot.com/10867058/diff/1/build/common.gypi#newc...
build/common.gypi:1692: 'conditions': [
Only difference from previous CL is this block.

[Nico, 2012-08-24 19:05:03]

Lgtm

You probably want to unconditionality add this to the PDF vendor code too,
so that people doing local nonofficial builds with PDF can still build. (Or
they can add that)
On Aug 24, 2012 11:44 AM, <scottmg@chromium.org> wrote:

> Reviewers: Nico,
>
>
> https://chromiumcodereview.**appspot.com/10867058/diff/1/**
>
build/common.gypi<https://chromiumcodereview.appspot.com/10867058/diff/1/build/common.gypi>
> File build/common.gypi (right):
>
> https://chromiumcodereview.**appspot.com/10867058/diff/1/**
>
build/common.gypi#newcode1692<https://chromiumcodereview.appspot.com/10867058/diff/1/build/common.gypi#newcode1692>
> build/common.gypi:1692: 'conditions': [
> Only difference from previous CL is this block.
>
> Description:
> Retry of warnings-as-errors for Windows third_party.
>
> Same as patch here:
https://chromiumcodereview.**appspot.com/10827429/<https://chromiumcodereview...
>
> except that warnings as errors is off if buildtype=Official. The previous
> CL
> was OK everywhere that's visible on build.chromium.org including
> "Official"
> but fails on internal builds.
>
> R=thakis@chromium.org
> BUG=126483, 140121, 143877
>
>
> Please review this at
https://chromiumcodereview.**appspot.com/10867058/<https://chromiumcodereview...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files:
>   M DEPS
>   M build/common.gypi
>   M skia/skia.gyp
>   M third_party/leveldatabase/env_**chromium.cc
>   M third_party/lzma_sdk/CpuArch.h
>   M third_party/lzma_sdk/README.**chromium
>   M third_party/mesa/mesa.gyp
>   M third_party/qcms/qcms.gyp
>   M third_party/yasm/yasm.gyp
>   M tools/memory_watcher/memory_**watcher.gyp
>
>
> Index: DEPS
> diff --git a/DEPS b/DEPS
> index 8b2aef959d8694e05f41be79295d44**b0abf4e877..**
> 154a3938a62849a7b08e858ac42f3e**1a68dc9613 100644
> --- a/DEPS
> +++ b/DEPS
> @@ -20,7 +20,7 @@ vars = {
>
>    "libjingle_revision": "170",
>    "libphonenumber_revision": "456",
> -  "libvpx_revision": "150392",
> +  "libvpx_revision": "152423",
>    "lss_revision": "11",
>
>    # These two FFmpeg variables must be updated together.  One is used for
> SVN
> Index: build/common.gypi
> diff --git a/build/common.gypi b/build/common.gypi
> index 734fa135754f8c709bc8701f508820**be4ed53eaa..**
> dd5a42616f7e60f21dfedf00ea277a**b0dc4435a2 100644
> --- a/build/common.gypi
> +++ b/build/common.gypi
> @@ -710,6 +710,14 @@
>      # to get incremental linking to be faster in debug builds.
>      'incremental_chrome_dll%': '0',
>
> +    # The default settings for third party code for treating
> +    # warnings-as-errors. Ideally, this would not be required, however
> there
> +    # is some third party code that takes a long time to fix/roll. So,
> this
> +    # flag allows us to have warnings as errors in general to prevent
> +    # regressions in most modules, while working on the bits that are
> +    # remaining.
> +    'win_third_party_warn_as_**error%': 'true',
> +
>      # This is the location of the sandbox binary. Chrome looks for this
> before
>      # running the zygote process. If found, and SUID, it will be used to
>      # sandbox the zygote process and, thus, all renderer processes.
> @@ -1677,10 +1685,17 @@
>              'msvs_settings': {
>                'VCCLCompilerTool': {
>                  'WarningLevel': '3',
> -                'WarnAsError': 'false', # TODO(maruel): Enable it.
> +                'WarnAsError': '<(win_third_party_warn_as_**error)',
>                  '**Detect64BitPortabilityProblems**': 'false',
>                },
>              },
> +            'conditions': [
> +              ['buildtype=="Official"', {
> +                'msvs_settings': {
> +                  'VCCLCompilerTool': { 'WarnAsError': 'false' },
> +                }
> +              }],
> +            ],
>            }],
>            # TODO(darin): Unfortunately, some third_party code depends on
> base/
>            [ 'OS=="win" and component=="shared_library"', {
> Index: skia/skia.gyp
> diff --git a/skia/skia.gyp b/skia/skia.gyp
> index 1615a3cbe1ef1b2fe94b73f41ac9de**0dfc54d309..**
> 0ae1c0e2b57ee91a5ae06ef5edbb7c**8433c56b20 100644
> --- a/skia/skia.gyp
> +++ b/skia/skia.gyp
> @@ -207,7 +207,7 @@
>          '../third_party/skia/src/sfnt'**,
>          '../third_party/skia/src/**utils',
>        ],
> -      'msvs_disabled_warnings': [4244, 4267, 4341, 4345, 4390, 4554,
> 4800],
> +      'msvs_disabled_warnings': [4244, 4267, 4341, 4345, 4390, 4554,
> 4748, 4800],
>        'defines': [
>          'SK_GAMMA_SRGB',
>          #'SK_GAMMA_APPLY_TO_A8',
> Index: third_party/leveldatabase/env_**chromium.cc
> diff --git a/third_party/leveldatabase/**env_chromium.cc
> b/third_party/leveldatabase/**env_chromium.cc
> index 6056de4771ec74d60f9558e017966d**82dc050c4b..**
> d1b4c26b53bce5582fcff1948dd725**eb3d5f8f32 100644
> --- a/third_party/leveldatabase/**env_chromium.cc
> +++ b/third_party/leveldatabase/**env_chromium.cc
> @@ -252,8 +252,7 @@ class ChromiumEnv : public Env {
>   public:
>    ChromiumEnv();
>    virtual ~ChromiumEnv() {
> -    fprintf(stderr, "Destroying Env::Default()\n");
> -    exit(1);
> +    NOTREACHED();
>    }
>
>    virtual Status NewSequentialFile(const std::string& fname,
> Index: third_party/lzma_sdk/CpuArch.h
> diff --git a/third_party/lzma_sdk/**CpuArch.h b/third_party/lzma_sdk/**
> CpuArch.h
> index 01930c7e67d4c7c5802be6034c30e9**4e4e85dcae..**
> 8c0c84d6fcb78621dac68d2f2facd1**5cad64904a 100644
> --- a/third_party/lzma_sdk/**CpuArch.h
> +++ b/third_party/lzma_sdk/**CpuArch.h
> @@ -4,6 +4,7 @@
>  #ifndef __CPU_ARCH_H
>  #define __CPU_ARCH_H
>
> +#include <stdlib.h>
>  #include "Types.h"
>
>  EXTERN_C_BEGIN
> Index: third_party/lzma_sdk/README.**chromium
> diff --git a/third_party/lzma_sdk/README.**chromium
> b/third_party/lzma_sdk/README.**chromium
> index d487eec3a38612ccee8663caf116a6**9471263670..**
> c9ea02f53241de5c99af594796eded**e8f70bacd3 100644
> --- a/third_party/lzma_sdk/README.**chromium
> +++ b/third_party/lzma_sdk/README.**chromium
> @@ -14,3 +14,6 @@ proper file paths and generate a static lib.
>
>  The patch in chromium.patch was applied to CpuArch.c to fix compile error
> on
>  32bit Linux.
> +
> +An #include <stdlib.h> needs to be added to CpuArch.h to avoid a warning
> on
> +Win32.
> Index: third_party/mesa/mesa.gyp
> diff --git a/third_party/mesa/mesa.gyp b/third_party/mesa/mesa.gyp
> index 1ed392c269e09786d03c1190ea5a7c**4f23ef7651..**
> a7e475d6e4f04e62da5fe5aed3e675**36f1153c66 100644
> --- a/third_party/mesa/mesa.gyp
> +++ b/third_party/mesa/mesa.gyp
> @@ -4,6 +4,9 @@
>
>  {
>    'variables': {
> +    # Disable warnings as errors for mesa until they're fixed or disabled.
> +    # http://crbug.com/143877
> +    'win_third_party_warn_as_**error': 'false',
>    },
>    'target_defaults': {
>      'conditions': [
> Index: third_party/qcms/qcms.gyp
> diff --git a/third_party/qcms/qcms.gyp b/third_party/qcms/qcms.gyp
> index 01b9543e99a9e37d2a328ed8bae237**067ab14ac9..**
> 0208b1e5e3cbd50253bb7e33545ea3**be4e334cc1 100644
> --- a/third_party/qcms/qcms.gyp
> +++ b/third_party/qcms/qcms.gyp
> @@ -26,6 +26,9 @@
>            './src',
>          ],
>        },
> +      # Warning (sign-conversion) fixed upstream by large refactoring.
> Can be
> +      # removed on next roll.
> +      'msvs_disabled_warnings': [ 4018 ],
>        'conditions': [
>          [ 'target_arch != "arm" and OS in ["linux", "freebsd", "openbsd",
> "solaris"]', {
>            'cflags': [
> Index: third_party/yasm/yasm.gyp
> diff --git a/third_party/yasm/yasm.gyp b/third_party/yasm/yasm.gyp
> index d981b509e9f6757336babd64558d8d**a1a6f989bd..**
> 90936006a234f21ce1423a9dffc23a**a65b70f053 100644
> --- a/third_party/yasm/yasm.gyp
> +++ b/third_party/yasm/yasm.gyp
> @@ -71,6 +71,9 @@
>          'genstring',
>          're2c',
>        ],
> +      # Patch to fix posted upstream, but not yet merged.
> +      #
https://github.com/yasm/yasm/**pull/64<https://github.com/yasm/yasm/pull/64>
> +      'msvs_disabled_warnings': [ 4018, 4090 ],
>        'sources': [
>           'source/patched-yasm/**frontends/yasm/yasm-options.c'**,
>           'source/patched-yasm/**frontends/yasm/yasm.c',
> Index: tools/memory_watcher/memory_**watcher.gyp
> diff --git a/tools/memory_watcher/memory_**watcher.gyp
> b/tools/memory_watcher/memory_**watcher.gyp
> index feed6f84651057a5ecb7d12bf6c94b**f8d1389370..**
> eb1970529ad709140fdb74ca8d26df**57243c35c9 100644
> --- a/tools/memory_watcher/memory_**watcher.gyp
> +++ b/tools/memory_watcher/memory_**watcher.gyp
> @@ -18,6 +18,10 @@
>          '../..',
>          '<(DEPTH)/third_party/wtl/**include',
>        ],
> +      # "/GS can not protect parameters and local variables from local
> buffer
> +      # overrun because optimizations are disabled in function". Nothing
> to be
> +      # done about this warning.
> +      'msvs_disabled_warnings': [ 4748 ],
>        'sources': [
>          'call_stack.cc',
>          'call_stack.h',
>
>
>

[scottmg, 2012-08-24 19:06:06]

Thanks. Trying to get access to pdf code, but I guess someone will yell at
me at some point and then I can get them to add it. :)

On Fri, Aug 24, 2012 at 12:05 PM, Nico Weber <thakis@chromium.org> wrote:

> Lgtm
>
> You probably want to unconditionality add this to the PDF vendor code too,
> so that people doing local nonofficial builds with PDF can still build. (Or
> they can add that)
> On Aug 24, 2012 11:44 AM, <scottmg@chromium.org> wrote:
>
>> Reviewers: Nico,
>>
>>
>> https://chromiumcodereview.**appspot.com/10867058/diff/1/**
>>
build/common.gypi<https://chromiumcodereview.appspot.com/10867058/diff/1/build/common.gypi>
>> File build/common.gypi (right):
>>
>> https://chromiumcodereview.**appspot.com/10867058/diff/1/**
>>
build/common.gypi#newcode1692<https://chromiumcodereview.appspot.com/10867058/diff/1/build/common.gypi#newcode1692>
>> build/common.gypi:1692: 'conditions': [
>> Only difference from previous CL is this block.
>>
>> Description:
>> Retry of warnings-as-errors for Windows third_party.
>>
>> Same as patch here:
https://chromiumcodereview.**appspot.com/10827429/<https://chromiumcodereview...
>>
>> except that warnings as errors is off if buildtype=Official. The previous
>> CL
>> was OK everywhere that's visible on build.chromium.org including
>> "Official"
>> but fails on internal builds.
>>
>> R=thakis@chromium.org
>> BUG=126483, 140121, 143877
>>
>>
>> Please review this at
https://chromiumcodereview.**appspot.com/10867058/<https://chromiumcodereview...
>>
>> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>>
>> Affected files:
>>   M DEPS
>>   M build/common.gypi
>>   M skia/skia.gyp
>>   M third_party/leveldatabase/env_**chromium.cc
>>   M third_party/lzma_sdk/CpuArch.h
>>   M third_party/lzma_sdk/README.**chromium
>>   M third_party/mesa/mesa.gyp
>>   M third_party/qcms/qcms.gyp
>>   M third_party/yasm/yasm.gyp
>>   M tools/memory_watcher/memory_**watcher.gyp
>>
>>
>> Index: DEPS
>> diff --git a/DEPS b/DEPS
>> index 8b2aef959d8694e05f41be79295d44**b0abf4e877..**
>> 154a3938a62849a7b08e858ac42f3e**1a68dc9613 100644
>> --- a/DEPS
>> +++ b/DEPS
>> @@ -20,7 +20,7 @@ vars = {
>>
>>    "libjingle_revision": "170",
>>    "libphonenumber_revision": "456",
>> -  "libvpx_revision": "150392",
>> +  "libvpx_revision": "152423",
>>    "lss_revision": "11",
>>
>>    # These two FFmpeg variables must be updated together.  One is used
>> for SVN
>> Index: build/common.gypi
>> diff --git a/build/common.gypi b/build/common.gypi
>> index 734fa135754f8c709bc8701f508820**be4ed53eaa..**
>> dd5a42616f7e60f21dfedf00ea277a**b0dc4435a2 100644
>> --- a/build/common.gypi
>> +++ b/build/common.gypi
>> @@ -710,6 +710,14 @@
>>      # to get incremental linking to be faster in debug builds.
>>      'incremental_chrome_dll%': '0',
>>
>> +    # The default settings for third party code for treating
>> +    # warnings-as-errors. Ideally, this would not be required, however
>> there
>> +    # is some third party code that takes a long time to fix/roll. So,
>> this
>> +    # flag allows us to have warnings as errors in general to prevent
>> +    # regressions in most modules, while working on the bits that are
>> +    # remaining.
>> +    'win_third_party_warn_as_**error%': 'true',
>> +
>>      # This is the location of the sandbox binary. Chrome looks for this
>> before
>>      # running the zygote process. If found, and SUID, it will be used to
>>      # sandbox the zygote process and, thus, all renderer processes.
>> @@ -1677,10 +1685,17 @@
>>              'msvs_settings': {
>>                'VCCLCompilerTool': {
>>                  'WarningLevel': '3',
>> -                'WarnAsError': 'false', # TODO(maruel): Enable it.
>> +                'WarnAsError': '<(win_third_party_warn_as_**error)',
>>                  '**Detect64BitPortabilityProblems**': 'false',
>>                },
>>              },
>> +            'conditions': [
>> +              ['buildtype=="Official"', {
>> +                'msvs_settings': {
>> +                  'VCCLCompilerTool': { 'WarnAsError': 'false' },
>> +                }
>> +              }],
>> +            ],
>>            }],
>>            # TODO(darin): Unfortunately, some third_party code depends on
>> base/
>>            [ 'OS=="win" and component=="shared_library"', {
>> Index: skia/skia.gyp
>> diff --git a/skia/skia.gyp b/skia/skia.gyp
>> index 1615a3cbe1ef1b2fe94b73f41ac9de**0dfc54d309..**
>> 0ae1c0e2b57ee91a5ae06ef5edbb7c**8433c56b20 100644
>> --- a/skia/skia.gyp
>> +++ b/skia/skia.gyp
>> @@ -207,7 +207,7 @@
>>          '../third_party/skia/src/sfnt'**,
>>          '../third_party/skia/src/**utils',
>>        ],
>> -      'msvs_disabled_warnings': [4244, 4267, 4341, 4345, 4390, 4554,
>> 4800],
>> +      'msvs_disabled_warnings': [4244, 4267, 4341, 4345, 4390, 4554,
>> 4748, 4800],
>>        'defines': [
>>          'SK_GAMMA_SRGB',
>>          #'SK_GAMMA_APPLY_TO_A8',
>> Index: third_party/leveldatabase/env_**chromium.cc
>> diff --git a/third_party/leveldatabase/**env_chromium.cc
>> b/third_party/leveldatabase/**env_chromium.cc
>> index 6056de4771ec74d60f9558e017966d**82dc050c4b..**
>> d1b4c26b53bce5582fcff1948dd725**eb3d5f8f32 100644
>> --- a/third_party/leveldatabase/**env_chromium.cc
>> +++ b/third_party/leveldatabase/**env_chromium.cc
>> @@ -252,8 +252,7 @@ class ChromiumEnv : public Env {
>>   public:
>>    ChromiumEnv();
>>    virtual ~ChromiumEnv() {
>> -    fprintf(stderr, "Destroying Env::Default()\n");
>> -    exit(1);
>> +    NOTREACHED();
>>    }
>>
>>    virtual Status NewSequentialFile(const std::string& fname,
>> Index: third_party/lzma_sdk/CpuArch.h
>> diff --git a/third_party/lzma_sdk/**CpuArch.h b/third_party/lzma_sdk/**
>> CpuArch.h
>> index 01930c7e67d4c7c5802be6034c30e9**4e4e85dcae..**
>> 8c0c84d6fcb78621dac68d2f2facd1**5cad64904a 100644
>> --- a/third_party/lzma_sdk/**CpuArch.h
>> +++ b/third_party/lzma_sdk/**CpuArch.h
>> @@ -4,6 +4,7 @@
>>  #ifndef __CPU_ARCH_H
>>  #define __CPU_ARCH_H
>>
>> +#include <stdlib.h>
>>  #include "Types.h"
>>
>>  EXTERN_C_BEGIN
>> Index: third_party/lzma_sdk/README.**chromium
>> diff --git a/third_party/lzma_sdk/README.**chromium
>> b/third_party/lzma_sdk/README.**chromium
>> index d487eec3a38612ccee8663caf116a6**9471263670..**
>> c9ea02f53241de5c99af594796eded**e8f70bacd3 100644
>> --- a/third_party/lzma_sdk/README.**chromium
>> +++ b/third_party/lzma_sdk/README.**chromium
>> @@ -14,3 +14,6 @@ proper file paths and generate a static lib.
>>
>>  The patch in chromium.patch was applied to CpuArch.c to fix compile
>> error on
>>  32bit Linux.
>> +
>> +An #include <stdlib.h> needs to be added to CpuArch.h to avoid a warning
>> on
>> +Win32.
>> Index: third_party/mesa/mesa.gyp
>> diff --git a/third_party/mesa/mesa.gyp b/third_party/mesa/mesa.gyp
>> index 1ed392c269e09786d03c1190ea5a7c**4f23ef7651..**
>> a7e475d6e4f04e62da5fe5aed3e675**36f1153c66 100644
>> --- a/third_party/mesa/mesa.gyp
>> +++ b/third_party/mesa/mesa.gyp
>> @@ -4,6 +4,9 @@
>>
>>  {
>>    'variables': {
>> +    # Disable warnings as errors for mesa until they're fixed or
>> disabled.
>> +    # http://crbug.com/143877
>> +    'win_third_party_warn_as_**error': 'false',
>>    },
>>    'target_defaults': {
>>      'conditions': [
>> Index: third_party/qcms/qcms.gyp
>> diff --git a/third_party/qcms/qcms.gyp b/third_party/qcms/qcms.gyp
>> index 01b9543e99a9e37d2a328ed8bae237**067ab14ac9..**
>> 0208b1e5e3cbd50253bb7e33545ea3**be4e334cc1 100644
>> --- a/third_party/qcms/qcms.gyp
>> +++ b/third_party/qcms/qcms.gyp
>> @@ -26,6 +26,9 @@
>>            './src',
>>          ],
>>        },
>> +      # Warning (sign-conversion) fixed upstream by large refactoring.
>> Can be
>> +      # removed on next roll.
>> +      'msvs_disabled_warnings': [ 4018 ],
>>        'conditions': [
>>          [ 'target_arch != "arm" and OS in ["linux", "freebsd",
>> "openbsd", "solaris"]', {
>>            'cflags': [
>> Index: third_party/yasm/yasm.gyp
>> diff --git a/third_party/yasm/yasm.gyp b/third_party/yasm/yasm.gyp
>> index d981b509e9f6757336babd64558d8d**a1a6f989bd..**
>> 90936006a234f21ce1423a9dffc23a**a65b70f053 100644
>> --- a/third_party/yasm/yasm.gyp
>> +++ b/third_party/yasm/yasm.gyp
>> @@ -71,6 +71,9 @@
>>          'genstring',
>>          're2c',
>>        ],
>> +      # Patch to fix posted upstream, but not yet merged.
>> +      #
https://github.com/yasm/yasm/**pull/64<https://github.com/yasm/yasm/pull/64>
>> +      'msvs_disabled_warnings': [ 4018, 4090 ],
>>        'sources': [
>>           'source/patched-yasm/**frontends/yasm/yasm-options.c'**,
>>           'source/patched-yasm/**frontends/yasm/yasm.c',
>> Index: tools/memory_watcher/memory_**watcher.gyp
>> diff --git a/tools/memory_watcher/memory_**watcher.gyp
>> b/tools/memory_watcher/memory_**watcher.gyp
>> index feed6f84651057a5ecb7d12bf6c94b**f8d1389370..**
>> eb1970529ad709140fdb74ca8d26df**57243c35c9 100644
>> --- a/tools/memory_watcher/memory_**watcher.gyp
>> +++ b/tools/memory_watcher/memory_**watcher.gyp
>> @@ -18,6 +18,10 @@
>>          '../..',
>>          '<(DEPTH)/third_party/wtl/**include',
>>        ],
>> +      # "/GS can not protect parameters and local variables from local
>> buffer
>> +      # overrun because optimizations are disabled in function". Nothing
>> to be
>> +      # done about this warning.
>> +      'msvs_disabled_warnings': [ 4748 ],
>>        'sources': [
>>          'call_stack.cc',
>>          'call_stack.h',
>>
>>
>>

[rvargas (doing something else), 2012-08-28 23:53:08]

This broke building the sandbox code under 64 bit.

1>------ Build started: Project: modp_b64, Configuration: Debug x64 ------
1>Compiling...
1>modp_b64.cc
1>d:\src\ch1\src\third_party\modp_b64\modp_b64.h(137) : error C2220: warning
treated as error - no 'object' file generated
1>d:\src\ch1\src\third_party\modp_b64\modp_b64.h(137) : warning C4267:
'argument' : conversion from 'size_t' to 'int', possible loss of data
1>d:\src\ch1\src\third_party\modp_b64\modp_b64.h(155) : warning C4267:
'argument' : conversion from 'size_t' to 'int', possible loss of data

----------------------

Note that this is not a configuration that we test in the waterfall, but it is a
supported configuration, required for NACL.

On second thoughts, it may be just a case of an undesired dependency on modp_b64
somewhere.

[scottmg, 2012-08-28 23:55:24]

On 2012/08/28 23:53:08, rvargas wrote:
> This broke building the sandbox code under 64 bit.
> 
> 1>------ Build started: Project: modp_b64, Configuration: Debug x64 ------
> 1>Compiling...
> 1>modp_b64.cc
> 1>d:\src\ch1\src\third_party\modp_b64\modp_b64.h(137) : error C2220: warning
> treated as error - no 'object' file generated
> 1>d:\src\ch1\src\third_party\modp_b64\modp_b64.h(137) : warning C4267:
> 'argument' : conversion from 'size_t' to 'int', possible loss of data
> 1>d:\src\ch1\src\third_party\modp_b64\modp_b64.h(155) : warning C4267:
> 'argument' : conversion from 'size_t' to 'int', possible loss of data
> 
> ----------------------
> 
> Note that this is not a configuration that we test in the waterfall, but it is
a
> supported configuration, required for NACL.
> 
> On second thoughts, it may be just a case of an undesired dependency on
modp_b64
> somewhere.

Sorry about that. If the warning's not easily fixable nor the dependency
removable we can add an exception similar to:
https://chromiumcodereview.appspot.com/10867058/diff/4001/third_party/mesa/me...