Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(638)

Issue 10867055: [net] Temporarily turn the AsyncDns field trial off (Closed)

Created:
8 years, 4 months ago by szym
Modified:
8 years, 4 months ago
Reviewers:
cbentzel
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

[net] Temporarily turn the AsyncDns field trial off Until we address check failures: http://crbug.com/121085 BUG=143454 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=153252

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/browser/net/async_dns_field_trial.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
szym
8 years, 4 months ago (2012-08-24 17:37:56 UTC) #1
cbentzel
8 years, 4 months ago (2012-08-24 18:42:26 UTC) #2
LGTM

On Fri, Aug 24, 2012 at 1:37 PM, <szym@chromium.org> wrote:

> Reviewers: cbentzel,
>
> Description:
> [net] Temporarily turn the AsyncDns field trial off
>
> BUG=143454
>
>
> Please review this at
http://codereview.chromium.**org/10867055/<http://codereview.chromium.org/108...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files:
>   M chrome/browser/net/async_dns_**field_trial.cc
>
>
> Index: chrome/browser/net/async_dns_**field_trial.cc
> diff --git a/chrome/browser/net/async_**dns_field_trial.cc
> b/chrome/browser/net/async_**dns_field_trial.cc
> index 58e4b0f9782a1b6b1c2fad7465da30**ae2f79b6e6..**
> b37028c905fe4c12ec5673cb8b6069**f519d6c3c3 100644
> --- a/chrome/browser/net/async_**dns_field_trial.cc
> +++ b/chrome/browser/net/async_**dns_field_trial.cc
> @@ -18,8 +18,9 @@ bool ConfigureAsyncDnsFieldTrial() {
>    const base::FieldTrial::Probability kAsyncDnsDivisor = 100;
>    base::FieldTrial::Probability enabled_probability = 0;
>
> +  // TODO(szym): bring the probability up after fixing
> http://crbug.com/121085
>    if (chrome::VersionInfo::**GetChannel() <=
> chrome::VersionInfo::CHANNEL_**DEV)
> -    enabled_probability = 50;
> +    enabled_probability = 0;
>
>    scoped_refptr<base::**FieldTrial> trial(
>        base::FieldTrialList::**FactoryGetFieldTrial(
>
>
>

Powered by Google App Engine
This is Rietveld 408576698