Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Issue 10867053: Revert 153206 - Re-enable Ctrl-w and Ctrl-Shift-w when a non-Pepper window is maximized. (Closed)

Created:
8 years, 4 months ago by Yusuke Sato
Modified:
8 years, 4 months ago
Reviewers:
Yusuke Sato
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 153206 - Re-enable Ctrl-w and Ctrl-Shift-w when a non-Pepper window is maximized. This is a temporary fix for M22 for crbug.com/143442, and should be reverted on trunk as part of crbug.com/142422. This CL is basically a second trial of r151121 which was also a temporary fix for M22. r151121 disabled Ctrl-w and Ctrl-Shift-w when any kind of full screen window was active, but it turned out that the limitation was too strict; we should not disable Ctrl-w and Ctrl-Shift-w when a non-Pepper window was maximized. BUG=143442, 142422 TEST=confirmed that C-w/C-S-w do not crash when a browser window is maximized. Review URL: https://chromiumcodereview.appspot.com/10834421 TBR=yusukes@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=153210

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M chrome/browser/ui/browser_command_controller.cc View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Yusuke Sato
8 years, 4 months ago (2012-08-24 14:47:53 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698