Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Unified Diff: runtime/vm/flow_graph_builder.cc

Issue 10867050: Separate branch on strict compare into a new IL instruction. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/il_printer.cc » ('j') | runtime/vm/intermediate_language.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/flow_graph_builder.cc
===================================================================
--- runtime/vm/flow_graph_builder.cc (revision 11303)
+++ runtime/vm/flow_graph_builder.cc (working copy)
@@ -276,11 +276,8 @@
}
const Bool& bool_true = Bool::ZoneHandle(Bool::True());
Value* constant_true = Bind(Constant(bool_true));
- BranchInstr* branch = new BranchInstr(condition_token_pos(),
- owner()->try_index(),
- value,
- constant_true,
- Token::kEQ_STRICT);
+ StrictCompareAndBranchInstr* branch =
+ new StrictCompareAndBranchInstr(value, constant_true, Token::kEQ_STRICT);
AddInstruction(branch);
CloseFragment();
true_successor_address_ = branch->true_successor_address();
@@ -306,11 +303,10 @@
ASSERT(!FLAG_enable_type_checks);
const Bool& bool_true = Bool::ZoneHandle(Bool::True());
Value* constant_true = Bind(Constant(bool_true));
- BranchInstr* branch = new BranchInstr(condition_token_pos(),
- owner()->try_index(),
- comp->value(),
- constant_true,
- Token::kNE_STRICT);
+ StrictCompareAndBranchInstr* branch =
+ new StrictCompareAndBranchInstr(comp->value(),
+ constant_true,
+ Token::kNE_STRICT);
AddInstruction(branch);
CloseFragment();
true_successor_address_ = branch->true_successor_address();
« no previous file with comments | « no previous file | runtime/vm/il_printer.cc » ('j') | runtime/vm/intermediate_language.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698