Issue 10867033: Disable speculative LICM when it may lead to unnecessary deopts

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10867033: Disable speculative LICM when it may lead to unnecessary deopts (Closed)

Created:
8 years, 4 months ago by danno

Modified:
8 years, 4 months ago

Reviewers:
Vyacheslav Egorov (Google), Vyacheslav Egorov (Chromium)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Disable speculative LICM when it may lead to unnecessary deopts BUG=v8:2250 R=vegorov@chromium.org TEST=tests/mjsunit/regress/regress-2250.js Committed: https://code.google.com/p/v8/source/detail?r=12375

Patch Set 1 #

Patch Set 2 : Fix nits #

Patch Set 3 : More tweaks #

Total comments: 1

Patch Set 4 : feedback addressed #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+182 lines, -33 lines)			Patch
M	src/heap.cc	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	src/hydrogen.h	View	1 2	2 chunks	+15 lines, -0 lines	0 comments	Download
M	src/hydrogen.cc	View	1 2	6 chunks	+31 lines, -2 lines	0 comments	Download
M	src/ic.cc	View		1 chunk	+7 lines, -3 lines	0 comments	Download
M	src/objects.h	View	1	2 chunks	+25 lines, -6 lines	0 comments	Download
M	src/objects-debug.cc	View	1 2 3	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/objects-inl.h	View		1 chunk	+71 lines, -3 lines	0 comments	Download
A +	test/mjsunit/regress/regress-2250.js	View	1	1 chunk	+30 lines, -15 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Vyacheslav Egorov (Google)

8 years, 4 months ago (2012-08-23 15:58:04 UTC) #2

lgtm

http://codereview.chromium.org/10867033/diff/3002/src/objects-debug.cc
File src/objects-debug.cc (right):

http://codereview.chromium.org/10867033/diff/3002/src/objects-debug.cc#newcod...
src/objects-debug.cc:347: VerifyObjectField(kStorage1Offset);
kStorage2Offset?

Expand Messages | Collapse Messages