Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 10867028: Set-up work for componentization of history. (Closed)

Created:
8 years, 4 months ago by erikwright (departed)
Modified:
8 years, 4 months ago
Reviewers:
sky, Jói
CC:
chromium-reviews, brettw-cc_chromium.org, browser-components-watch_chromium.org, Nirnimesh
Visibility:
Public.

Description

Set-up work for componentization of history. R=joi,sky BUG=144050 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=153259

Patch Set 1 #

Total comments: 1

Patch Set 2 : nit. #

Total comments: 1

Patch Set 3 : revert OWNERS #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -1 line) Patch
M WATCHLISTS View 1 chunk +1 line, -1 line 0 comments Download
A chrome/browser/history/DEPS View 1 1 chunk +59 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
erikwright (departed)
8 years, 4 months ago (2012-08-23 01:54:22 UTC) #1
Jói
LGTM https://chromiumcodereview.appspot.com/10867028/diff/1/chrome/browser/history/DEPS File chrome/browser/history/DEPS (right): https://chromiumcodereview.appspot.com/10867028/diff/1/chrome/browser/history/DEPS#newcode45 chrome/browser/history/DEPS:45: specific_include_rules = { nit: suggest empty line before ...
8 years, 4 months ago (2012-08-23 09:21:21 UTC) #2
erikwright (departed)
sky: PTAL. Our convention is to add a Browser Components team member to each component's ...
8 years, 4 months ago (2012-08-23 18:29:27 UTC) #3
sky
http://codereview.chromium.org/10867028/diff/4001/chrome/browser/history/OWNERS File chrome/browser/history/OWNERS (right): http://codereview.chromium.org/10867028/diff/4001/chrome/browser/history/OWNERS#newcode5 chrome/browser/history/OWNERS:5: erikwright@chromium.org I would rather see you TBR changes you ...
8 years, 4 months ago (2012-08-23 19:48:24 UTC) #4
erikwright (departed)
Removed OWNERS from this CL. This is something we felt would help optimize things but ...
8 years, 4 months ago (2012-08-23 21:20:15 UTC) #5
Jói
The intent with adding ourselves to OWNERS files was that we could do "safe refactoring" ...
8 years, 4 months ago (2012-08-23 21:22:20 UTC) #6
sky
LGTM
8 years, 4 months ago (2012-08-24 16:07:13 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erikwright@chromium.org/10867028/1006
8 years, 4 months ago (2012-08-24 17:21:41 UTC) #8
commit-bot: I haz the power
8 years, 4 months ago (2012-08-24 19:45:13 UTC) #9
Change committed as 153259

Powered by Google App Engine
This is Rietveld 408576698