Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(714)

Side by Side Diff: src/hydrogen.cc

Issue 10867017: When processing collected uint32 instructions skip those with non-Integer32 representation. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 2915 matching lines...) Expand 10 before | Expand all | Expand 10 after
2926 2926
2927 2927
2928 void HGraph::ComputeSafeUint32Operations() { 2928 void HGraph::ComputeSafeUint32Operations() {
2929 if (!FLAG_opt_safe_uint32_operations || uint32_instructions_ == NULL) { 2929 if (!FLAG_opt_safe_uint32_operations || uint32_instructions_ == NULL) {
2930 return; 2930 return;
2931 } 2931 }
2932 2932
2933 Uint32Analysis analysis(zone()); 2933 Uint32Analysis analysis(zone());
2934 for (int i = 0; i < uint32_instructions_->length(); ++i) { 2934 for (int i = 0; i < uint32_instructions_->length(); ++i) {
2935 HInstruction* current = uint32_instructions_->at(i); 2935 HInstruction* current = uint32_instructions_->at(i);
2936 if (current->IsLinked()) analysis.Analyze(current); 2936 if (current->IsLinked() && current->representation().IsInteger32()) {
2937 analysis.Analyze(current);
2938 }
2937 } 2939 }
2938 2940
2939 // Some phis might have been optimistically marked with kUint32 flag. 2941 // Some phis might have been optimistically marked with kUint32 flag.
2940 // Remove this flag from those phis that are unsafe and propagate 2942 // Remove this flag from those phis that are unsafe and propagate
2941 // this information transitively potentially clearing kUint32 flag 2943 // this information transitively potentially clearing kUint32 flag
2942 // from some non-phi operations that are used as operands to unsafe phis. 2944 // from some non-phi operations that are used as operands to unsafe phis.
2943 analysis.UnmarkUnsafePhis(); 2945 analysis.UnmarkUnsafePhis();
2944 } 2946 }
2945 2947
2946 2948
(...skipping 6986 matching lines...) Expand 10 before | Expand all | Expand 10 after
9933 } 9935 }
9934 } 9936 }
9935 9937
9936 #ifdef DEBUG 9938 #ifdef DEBUG
9937 if (graph_ != NULL) graph_->Verify(false); // No full verify. 9939 if (graph_ != NULL) graph_->Verify(false); // No full verify.
9938 if (allocator_ != NULL) allocator_->Verify(); 9940 if (allocator_ != NULL) allocator_->Verify();
9939 #endif 9941 #endif
9940 } 9942 }
9941 9943
9942 } } // namespace v8::internal 9944 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698