Add a smi-check instruction for arithmetic smi operations.

runtime/vm/intermediate_language_ia32.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/globals.h"  // Needed here to get TARGET_ARCH_IA32.
 #if defined(TARGET_ARCH_IA32)
 
 #include "vm/intermediate_language.h"
 
 #include "lib/error.h"
@@ skipping 1408 matching lines @@
         new LocationSummary(kNumInputs, kNumTemps, LocationSummary::kNoCall);
     summary->set_in(0, Location::RegisterLocation(EAX));
     summary->set_in(1, Location::RegisterLocation(ECX));
     summary->set_out(Location::SameAsFirstInput());
     summary->set_temp(0, Location::RegisterLocation(EBX));
     // Will be used for for sign extension.
     summary->set_temp(1, Location::RegisterLocation(EDX));
     summary->set_temp(2, Location::RequiresRegister());
     return summary;
   } else if (op_kind() == Token::kSHR) {
-    const intptr_t kNumTemps = 1;
+    const intptr_t kNumTemps = 0;
     LocationSummary* summary =
         new LocationSummary(kNumInputs, kNumTemps, LocationSummary::kNoCall);
     summary->set_in(0, Location::RequiresRegister());
     summary->set_in(1, Location::RegisterLocation(ECX));
     summary->set_out(Location::SameAsFirstInput());
-    summary->set_temp(0, Location::RequiresRegister());
     return summary;
   } else if (op_kind() == Token::kSHL) {
     // Two Smi operands can easily overflow into Mint.
     const intptr_t kNumTemps = 2;
     LocationSummary* summary =
         new LocationSummary(kNumInputs, kNumTemps, LocationSummary::kCall);
     summary->set_in(0, Location::RegisterLocation(EAX));
     summary->set_in(1, Location::RegisterLocation(EDX));
     summary->set_temp(0, Location::RegisterLocation(EBX));
     summary->set_temp(1, Location::RegisterLocation(ECX));
     summary->set_out(Location::RegisterLocation(EAX));
     return summary;
   } else {
-    const intptr_t kNumTemps = 1;
+    const intptr_t kNumTemps = 0;
     LocationSummary* summary =
         new LocationSummary(kNumInputs, kNumTemps, LocationSummary::kNoCall);
     summary->set_in(0, Location::RequiresRegister());
     summary->set_in(1, Location::RequiresRegister());
     summary->set_out(Location::SameAsFirstInput());
-    summary->set_temp(0, Location::RequiresRegister());
     return summary;
   }
 }
 
 
 void BinarySmiOpComp::EmitNativeCode(FlowGraphCompiler* compiler) {
   Register left = locs()->in(0).reg();
   Register right = locs()->in(1).reg();
   Register result = locs()->out().reg();
-  Register temp = locs()->temp(0).reg();
   ASSERT(left == result);
-  const bool left_is_smi = this->left()->ResultCid() == kSmiCid;
-  const bool right_is_smi = this->right()->ResultCid() == kSmiCid;
-  bool can_deopt;
+  Label* deopt = NULL;
   switch (op_kind()) {
     case Token::kBIT_AND:
     case Token::kBIT_OR:
     case Token::kBIT_XOR:
-      can_deopt = !(right_is_smi && left_is_smi);
+      // Can't deoptimize. Arguments are already checked for smi.
       break;
     default:
-      can_deopt = true;
+      deopt  = compiler->AddDeoptStub(instance_call()->deopt_id(),
+                                      instance_call()->try_index(),
+                                      kDeoptBinarySmiOp);
   }
-  Label* deopt = NULL;
-  if (can_deopt) {
-    deopt  = compiler->AddDeoptStub(instance_call()->deopt_id(),
-                                    instance_call()->try_index(),
-                                    kDeoptBinarySmiOp);
-  }
-  if (!left_is_smi || !right_is_smi) {
-    __ movl(temp, left);
-    __ orl(temp, right);
-    __ testl(temp, Immediate(kSmiTagMask));
-    __ j(NOT_ZERO, deopt);
-  }
+
   switch (op_kind()) {
     case Token::kADD: {
       __ addl(left, right);
       __ j(OVERFLOW, deopt);
       break;
     }
     case Token::kSUB: {
       __ subl(left, right);
       __ j(OVERFLOW, deopt);
       break;
@@ skipping 13 matching lines @@
       // No overflow check.
       __ orl(left, right);
       break;
     }
     case Token::kBIT_XOR: {
       // No overflow check.
       __ xorl(left, right);
       break;
     }
     case Token::kTRUNCDIV: {
+      Register temp = locs()->temp(0).reg();
       // Handle divide by zero in runtime.
       // Deoptimization requires that temp and right are preserved.
       __ testl(right, right);
       __ j(ZERO, deopt);
       ASSERT(left == EAX);
       ASSERT((right != EDX) && (right != EAX));
       ASSERT((temp != EDX) && (temp != EAX));
       ASSERT(locs()->temp(1).reg() == EDX);
       ASSERT(result == EAX);
       Register right_temp = locs()->temp(2).reg();
@@ skipping 20 matching lines @@
       __ j(LESS, &count_ok, Assembler::kNearJump);
       __ movl(right, kCountLimit);
       __ Bind(&count_ok);
       ASSERT(right == ECX);  // Count must be in ECX
       __ SmiUntag(left);
       __ sarl(left, right);
       __ SmiTag(left);
       break;
     }
     case Token::kSHL: {
+      Register temp = locs()->temp(0).reg();
       Label call_method, done;
       // Check if count too large for handling it inlined.
       __ movl(temp, left);
       __ cmpl(right,
           Immediate(reinterpret_cast<int64_t>(Smi::New(Smi::kBits))));
       __ j(ABOVE_EQUAL, &call_method, Assembler::kNearJump);
       Register right_temp = locs()->temp(1).reg();
       ASSERT(right_temp == ECX);  // Count must be in ECX
       __ movl(right_temp, right);
       __ SmiUntag(right_temp);
@@ skipping 611 matching lines @@
       if (use_near_jump) {
         __ j(EQUAL, &is_ok, Assembler::kNearJump);
       } else {
         __ j(EQUAL, &is_ok);
       }
     }
   }
   __ Bind(&is_ok);
 }
 
+
+LocationSummary* CheckSmiComp::MakeLocationSummary() const {
+  const intptr_t kNumInputs = 1;
+  const intptr_t kNumTemps = 0;
+  LocationSummary* summary =
+      new LocationSummary(kNumInputs, kNumTemps, LocationSummary::kNoCall);
+  summary->set_in(0, Location::RequiresRegister());
+  return summary;
+}
+
+
+void CheckSmiComp::EmitNativeCode(FlowGraphCompiler* compiler) {
+  Register value = locs()->in(0).reg();
+  Label* deopt = compiler->AddDeoptStub(deopt_id(),
+                                        try_index(),
+                                        kDeoptCheckSmi);
+  __ testl(value, Immediate(kSmiTagMask));
+  __ j(NOT_ZERO, deopt);
+}
+
+
 }  // namespace dart
 
 #undef __
 
 #endif  // defined TARGET_ARCH_X64