Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Issue 10867010: chrome: Start copying ui_test_utils_* files into their new locations. (Closed)

Created:
8 years, 4 months ago by tfarina
Modified:
8 years, 3 months ago
CC:
chromium-reviews, tfarina
Visibility:
Public.

Description

chrome: Start copying ui_test_utils_* files into their new locations. BUG=125846 TBR=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=153425

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+-4 lines, --4 lines) Patch
A + chrome/browser/ui/cocoa/test/ui_test_utils_mac.mm View 0 chunks +-1 lines, --1 lines 1 comment Download
A + chrome/browser/ui/gtk/test/ui_test_utils_gtk.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/ui/views/test/ui_test_utils_aura.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/ui/views/test/ui_test_utils_win.cc View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
tfarina
TBRing... http://codereview.chromium.org/10867010/diff/1/chrome/browser/ui/cocoa/test/ui_test_utils_mac.mm File chrome/browser/ui/cocoa/test/ui_test_utils_mac.mm (right): http://codereview.chromium.org/10867010/diff/1/chrome/browser/ui/cocoa/test/ui_test_utils_mac.mm#newcode5 chrome/browser/ui/cocoa/test/ui_test_utils_mac.mm:5: #include "chrome/test/base/ui_test_utils.h" Do we want to have ui_test_utils.h ...
8 years, 4 months ago (2012-08-22 13:26:51 UTC) #1
Ben Goodger (Google)
8 years, 4 months ago (2012-08-22 16:04:02 UTC) #2
LGTM, provided these are still built as part of a separate test target
(i.e. don't end up in production chrome)


On Wed, Aug 22, 2012 at 6:26 AM, <tfarina@chromium.org> wrote:

> Reviewers: Ben Goodger (Google),
>
> Message:
> TBRing...
>
>
> http://codereview.chromium.**org/10867010/diff/1/chrome/**
>
browser/ui/cocoa/test/ui_test_**utils_mac.mm<http://codereview.chromium.org/10867010/diff/1/chrome/browser/ui/cocoa/test/ui_test_utils_mac.mm>
> File
chrome/browser/ui/cocoa/test/u**i_test_utils_mac.mm<http://ui_test_utils_mac.mm>(right):
>
> http://codereview.chromium.**org/10867010/diff/1/chrome/**
>
browser/ui/cocoa/test/ui_test_**utils_mac.mm#newcode5<http://codereview.chromium.org/10867010/diff/1/chrome/browser/ui/cocoa/test/ui_test_utils_mac.mm#newcode5>
>
chrome/browser/ui/cocoa/test/u**i_test_utils_mac.mm:5<http://ui_test_utils_mac.mm:5>:
> #include
> "chrome/test/base/ui_test_**utils.h"
> Do we want to have ui_test_utils.h in chrome/browser/ui/test? I think it
> makes sense.
>
> Description:
> chrome: Start copying ui_test_utils_* files into their new locations.
>
> BUG=125846
> TBR=ben@chromium.org
>
>
> Please review this at
http://codereview.chromium.**org/10867010/<http://codereview.chromium.org/108...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files:
>   A +
chrome/browser/ui/cocoa/test/u**i_test_utils_mac.mm<http://ui_test_utils_mac.mm>
>   A + chrome/browser/ui/gtk/test/ui_**test_utils_gtk.cc
>   A + chrome/browser/ui/views/test/**ui_test_utils_aura.cc
>   A + chrome/browser/ui/views/test/**ui_test_utils_win.cc
>
>
> Index:
chrome/browser/ui/cocoa/test/u**i_test_utils_mac.mm<http://ui_test_utils_mac.mm>
> diff --git
a/chrome/test/base/ui_test_**utils_mac.mm<http://ui_test_utils_mac.mm>b/chrome/browser/ui/cocoa/
> **test/ui_test_utils_mac.mm
> similarity index 100%
> copy from
chrome/test/base/ui_test_**utils_mac.mm<http://ui_test_utils_mac.mm>
> copy to
chrome/browser/ui/cocoa/test/u**i_test_utils_mac.mm<http://ui_test_utils_mac.mm>
> Index: chrome/browser/ui/gtk/test/ui_**test_utils_gtk.cc
> diff --git a/chrome/test/base/ui_test_**utils_gtk.cc
> b/chrome/browser/ui/gtk/test/**ui_test_utils_gtk.cc
> similarity index 100%
> copy from chrome/test/base/ui_test_**utils_gtk.cc
> copy to chrome/browser/ui/gtk/test/ui_**test_utils_gtk.cc
> Index: chrome/browser/ui/views/test/**ui_test_utils_aura.cc
> diff --git a/chrome/test/base/ui_test_**utils_aura.cc
> b/chrome/browser/ui/views/**test/ui_test_utils_aura.cc
> similarity index 100%
> copy from chrome/test/base/ui_test_**utils_aura.cc
> copy to chrome/browser/ui/views/test/**ui_test_utils_aura.cc
> Index: chrome/browser/ui/views/test/**ui_test_utils_win.cc
> diff --git a/chrome/test/base/ui_test_**utils_win.cc
> b/chrome/browser/ui/views/**test/ui_test_utils_win.cc
> similarity index 100%
> copy from chrome/test/base/ui_test_**utils_win.cc
> copy to chrome/browser/ui/views/test/**ui_test_utils_win.cc
>
>
>

Powered by Google App Engine
This is Rietveld 408576698