Issue 10867009: platform: fix semaphore on mac os

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10867009: platform: fix semaphore on mac os

Created:
8 years, 4 months ago by indutny

Modified:
8 years, 4 months ago

Reviewers:
Erik Corry

Base URL:
gh:v8/v8@master

Visibility:
Public.

More Reviews

Description

platform: fix semaphore on mac os The comment above MacOSSemaphore::Wait() is simply not true :) R=erik.corry@gmail.com

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : added test case #

Patch Set 4 : assertions, fix lint #

Patch Set 5 : the last lint fix #

Total comments: 1

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+87 lines, -6 lines)			Patch
	M	src/platform-macos.cc	View	1 2 3	1 chunk	+17 lines, -6 lines	1 comment	Download
	M	test/cctest/test-api.cc	View	1 2 3 4	2 chunks	+70 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

indutny

Added test, changed crashing to asserting, fixed linting.

8 years, 4 months ago (2012-08-22 17:45:42 UTC) #2

Erik Corry

8 years, 4 months ago (2012-08-23 09:23:39 UTC) #3

LGTM, thanks, I will land.

https://chromiumcodereview.appspot.com/10867009/diff/6002/src/platform-macos.cc
File src/platform-macos.cc (right):

https://chromiumcodereview.appspot.com/10867009/diff/6002/src/platform-macos....
src/platform-macos.cc:705: ASSERT(r == KERN_SUCCESS);
I will move this up into the loop and assert that it is either SUCCESS or
ABORTED.  That way it doesn't loop if the assumption is wrong.

Expand Messages | Collapse Messages