Notify print preview UI if getting capabilityes failed.

Added failedToGetPrinterCapabilities JS event and empty handler.
Don't send updateWithPrinterCapabilities if GetPrinterCapabilities failed.
GetPrinterCapabilitiesCUPS and GetPrinterCapabilitiesWin replaced with ParsePrinterCapabilities with cross-platform interface.

BUG=144056
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=152830

[Vitaly Buka (NO REVIEWS), 2012-08-22 00:54:15]

Please review.

[Albert Bodenhamer, 2012-08-22 01:02:23]

http://codereview.chromium.org/10867004/diff/3001/chrome/browser/printing/pri...
File chrome/browser/printing/print_system_task_proxy.cc (right):

http://codereview.chromium.org/10867004/diff/3001/chrome/browser/printing/pri...
chrome/browser/printing/print_system_task_proxy.cc:382: bool
PrintSystemTaskProxy::ParsePrinterCapabilities(
Prototype is the same on all platforms.  Move the #if inside the function.

[Robert Toscano, 2012-08-22 01:05:31]

This looks awesome!

https://chromiumcodereview.appspot.com/10867004/diff/3001/chrome/browser/prin...
File chrome/browser/printing/print_system_task_proxy.cc (right):

https://chromiumcodereview.appspot.com/10867004/diff/3001/chrome/browser/prin...
chrome/browser/printing/print_system_task_proxy.cc:579:
handler_->SendFailedToGetPrinterCapabilities(printer_name);
Is it Google C++ to leave off curlies on one-liner ifs?

https://chromiumcodereview.appspot.com/10867004/diff/3001/chrome/browser/prin...
File chrome/browser/printing/print_system_task_proxy.h (right):

https://chromiumcodereview.appspot.com/10867004/diff/3001/chrome/browser/prin...
chrome/browser/printing/print_system_task_proxy.h:67: bool
ParsePrinterCapabilities(
Did you mean to remove the "static" modifier?

https://chromiumcodereview.appspot.com/10867004/diff/3001/chrome/browser/reso...
File chrome/browser/resources/print_preview/native_layer.js (right):

https://chromiumcodereview.appspot.com/10867004/diff/3001/chrome/browser/reso...
chrome/browser/resources/print_preview/native_layer.js:416: * @param {Object}
printer_name printer affected by error.
should be "@param {string} printerName ..."

https://chromiumcodereview.appspot.com/10867004/diff/3001/chrome/browser/reso...
chrome/browser/resources/print_preview/native_layer.js:419:
onFailedToGetPrinterCapabilities_: function(printer_name) {
Plz use camel case for var names: printerName

[Albert Bodenhamer, 2012-08-22 01:09:41]

https://chromiumcodereview.appspot.com/10867004/diff/3001/chrome/browser/prin...
File chrome/browser/printing/print_system_task_proxy.cc (right):

https://chromiumcodereview.appspot.com/10867004/diff/3001/chrome/browser/prin...
chrome/browser/printing/print_system_task_proxy.cc:579:
handler_->SendFailedToGetPrinterCapabilities(printer_name);
On 2012/08/22 01:05:31, Robert Toscano wrote:
> Is it Google C++ to leave off curlies on one-liner ifs?

It's the preferred Chrome style.  I personally dislike it, but I've stopped
commenting on it either way.

[Albert Bodenhamer, 2012-08-22 01:11:02]

Try jobs are failing.  Looks like the errors might be real.


On Tue, Aug 21, 2012 at 6:09 PM, <abodenha@chromium.org> wrote:

>
> https://chromiumcodereview.**appspot.com/10867004/diff/**
>
3001/chrome/browser/printing/**print_system_task_proxy.cc<https://chromiumcodereview.appspot.com/10867004/diff/3001/chrome/browser/printing/print_system_task_proxy.cc>
> File chrome/browser/printing/print_**system_task_proxy.cc (right):
>
> https://chromiumcodereview.**appspot.com/10867004/diff/**
>
3001/chrome/browser/printing/**print_system_task_proxy.cc#**newcode579<https://chromiumcodereview.appspot.com/10867004/diff/3001/chrome/browser/printing/print_system_task_proxy.cc#newcode579>
> chrome/browser/printing/print_**system_task_proxy.cc:579:
> handler_->**SendFailedToGetPrinterCapabili**ties(printer_name);
> On 2012/08/22 01:05:31, Robert Toscano wrote:
>
>> Is it Google C++ to leave off curlies on one-liner ifs?
>>
>
> It's the preferred Chrome style.  I personally dislike it, but I've
> stopped commenting on it either way.
>
>
https://chromiumcodereview.**appspot.com/10867004/<https://chromiumcodereview...
>



-- 
Albert Bodenhamer | Software Engineer | abodenha@chromium.<abodenha@google.com>
org

[Vitaly Buka (NO REVIEWS), 2012-08-22 02:58:02]

https://chromiumcodereview.appspot.com/10867004/diff/3001/chrome/browser/prin...
File chrome/browser/printing/print_system_task_proxy.cc (right):

https://chromiumcodereview.appspot.com/10867004/diff/3001/chrome/browser/prin...
chrome/browser/printing/print_system_task_proxy.cc:382: bool
PrintSystemTaskProxy::ParsePrinterCapabilities(
On 2012/08/22 01:02:23, Albert Bodenhamer wrote:
> Prototype is the same on all platforms.  Move the #if inside the function.

Done.

https://chromiumcodereview.appspot.com/10867004/diff/3001/chrome/browser/prin...
chrome/browser/printing/print_system_task_proxy.cc:579:
handler_->SendFailedToGetPrinterCapabilities(printer_name);
On 2012/08/22 01:05:31, Robert Toscano wrote:
> Is it Google C++ to leave off curlies on one-liner ifs?

Both styles are allowed.

https://chromiumcodereview.appspot.com/10867004/diff/3001/chrome/browser/prin...
File chrome/browser/printing/print_system_task_proxy.h (right):

https://chromiumcodereview.appspot.com/10867004/diff/3001/chrome/browser/prin...
chrome/browser/printing/print_system_task_proxy.h:67: bool
ParsePrinterCapabilities(
On 2012/08/22 01:05:31, Robert Toscano wrote:
> Did you mean to remove the "static" modifier?

Yes. CUPS can be static, WIN can't. But static does not worth splitting.

[Albert Bodenhamer, 2012-08-22 17:53:29]

lgtm

[commit-bot: I haz the power, 2012-08-22 17:54:07]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/10867004/4009

[commit-bot: I haz the power, 2012-08-22 19:20:20]

Try job failure for 10867004-4009 (retry) on win for step "compile" (clobber
build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number...

[commit-bot: I haz the power, 2012-08-22 19:23:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/10867004/4009

[commit-bot: I haz the power, 2012-08-22 21:50:46]

Change committed as 152830

[Robert Toscano, 2012-08-22 22:14:33]

I think you forgot to address my suggestions. I'll do it in a subsequent patch
though.

[Vitaly Buka (NO REVIEWS), 2012-08-22 22:20:56]

On 2012/08/22 22:14:33, Robert Toscano wrote:
> I think you forgot to address my suggestions. I'll do it in a subsequent patch
> though.

Sorry. Somehow I missed them.

[Vitaly Buka (NO REVIEWS), 2012-08-25 00:25:44]

Please review, just in case we are going to merge that to M21.