chrome/browser/extensions/api/tabs/tabs.cc - Issue 10863002: Added check to prevent extensions from injecting scrips into other extensions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/tabs/tabs.cc

Issue 10863002: Added check to prevent extensions from injecting scrips into other extensions (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: added test cases for self injection... and failed injection attempt Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/tabs/execute_code_in_tab_function.cc ('k') | chrome/browser/extensions/content_script_apitest.cc » ('j') | chrome/common/extensions/extension.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/tabs/tabs.cc

diff --git a/chrome/browser/extensions/api/tabs/tabs.cc b/chrome/browser/extensions/api/tabs/tabs.cc

index 99d87491b30d6b2c735e7b617a2d8c0e09bc6b2e..6a7f83c51cc847003c1f02c6a90ad05620b3faf6 100644

--- a/chrome/browser/extensions/api/tabs/tabs.cc

+++ b/chrome/browser/extensions/api/tabs/tabs.cc

@@ -1307,7 +1307,11 @@ bool UpdateTabFunction::UpdateURLIfPresent(DictionaryValue* update_props,

// we need to check host permissions before allowing them.

if (url.SchemeIs(chrome::kJavaScriptScheme)) {

if (!GetExtension()->CanExecuteScriptOnPage(

- tab_contents_->web_contents()->GetURL(), tab_id, NULL, &error_)) {

+ tab_contents_->web_contents()->GetURL(),

+ tab_id,

+ NULL,

+ &error_)) {

return false;

}