Issue 10861025: Data for http://codereview.chromium.org/10855260/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10861025: Data for http://codereview.chromium.org/10855260/ (Closed)

Created:
8 years, 4 months ago by mattm

Modified:
8 years, 4 months ago

Reviewers:
csilv

CC:
chromium-reviews, arv (Not doing code reviews), oshima+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Data for http://codereview.chromium.org/10855260/ BUG=143999 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=152896

Patch Set 1 #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs			Patch
A	chrome/app/theme/chromium/product_logo_name_108.png	View	+-1 lines, --1 lines	0 comments	Download
A	chrome/browser/resources/safe_browsing/images/malware_icon_v2.jpg	View	+-1 lines, --1 lines	0 comments	Download
A	chrome/browser/resources/safe_browsing/images/stripe.png	View	+-1 lines, --1 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

csilv

lgtm Note that we really should have 2x images for display on HiDPI devices. This ...

8 years, 4 months ago (2012-08-23 00:13:51 UTC) #2

mattm

8 years, 4 months ago (2012-08-23 00:28:29 UTC) #3

On 2012/08/23 00:13:51, csilv wrote:
> lgtm
> 
> Note that we really should have 2x images for display on HiDPI devices.  This
> will require some changes to the css/html to properly detect which image to
> display.  Please file a bug to have this done, we should really try to get
those
> included when this feature goes live.

These are actually 2x the needed size, since I heard that you should just use a
larger image and set the width/height on the image tag to half.  Sounds like
there is more to it.  Is there a doc somewhere about it?

Expand Messages | Collapse Messages