Introduce renameNodes helper to factor out common pattern.

lib/compiler/implementation/dart_backend/renamer.dart

Index: lib/compiler/implementation/dart_backend/renamer.dart
diff --git a/lib/compiler/implementation/dart_backend/renamer.dart b/lib/compiler/implementation/dart_backend/renamer.dart
index 6cb47f76933ce788de7d7a7ba4b5556e60b75b84..1f5ba60b47e63263dbe541bf90591b3191061750 100644
--- a/lib/compiler/implementation/dart_backend/renamer.dart
+++ b/lib/compiler/implementation/dart_backend/renamer.dart
@@ -50,35 +50,32 @@ void renamePlaceholders(
                    () => generateUniqueName(originalName));
   }
 
-  placeholderCollector.nullNodes.forEach((Node node) {
-    renames[node] = '';
-  });
-  placeholderCollector.unresolvedNodes.forEach((Node node) {
-    renames[node] = generateUniqueName('Unresolved');
-  });
+  renameNodes(Collection<Node> nodes, renamer) {
+    for (Node node in nodes) {
+      renames[node] = renamer(node);
+    }
+  }
+
+  renameNodes(placeholderCollector.nullNodes, (_) => '');

[Roman, 2012/08/21 08:02:44]

did you use '_' instead of 'node' to save 3 chars and not confuse reader? same
below

[Anton Muhin, 2012/08/21 09:11:10]

That's the common idiom to mark unused argument.  There is even a proposal to
make supported by language to allow (_, _, _, x) => x.

On 2012/08/21 08:02:44, Roman wrote:

+  renameNodes(placeholderCollector.unresolvedNodes,
+      (_) => generateUniqueName('Unresolved'));
   placeholderCollector.elementNodes.forEach(
       (Element element, Set<Node> nodes) {
         String renamedElement = renameElement(element);
-        nodes.forEach((Node node) {
-          renames[node] = renamedElement;
-        });
+        renameNodes(nodes, (_) => renamedElement);
   });
   placeholderCollector.localPlaceholders.forEach(
       (FunctionElement element, Set<LocalPlaceholder> localPlaceholders) {
         // TODO(smok): Check for conflicts with class fields and take usages
         // into account.
         localPlaceholders.forEach((LocalPlaceholder placeholder) {
-          placeholder.nodes.forEach((Node node) {
-            renames[node] = placeholder.identifier;
-          });
+          renameNodes(placeholder.nodes, (_) => placeholder.identifier);
         });
       });
   placeholderCollector.privateNodes.forEach(
       (LibraryElement library, Set<Identifier> nodes) {
-        nodes.forEach((Identifier node) {
-          renames[node] =
-              renamePrivateIdentifier(library, node.source.slowToString());
-        });
+        renameNodes(nodes, (node) =>
+            renamePrivateIdentifier(library, node.source.slowToString()));
   });
 }