Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 10861015: gdata: Add GDataDirectoryService::GetEntryInfoByResourceId() (Closed)

Created:
8 years, 4 months ago by satorux1
Modified:
8 years, 4 months ago
Reviewers:
achuithb
CC:
chromium-reviews, achuith+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

gdata: Add GDataDirectoryService::GetEntryInfoByResourceId() Similar to GDataDirectoryService::GetEntryByResourceIdAsync() but this one returns a proto instead of GDataEntry*. This function will be used to replace use of GDataDirectoryService::GetEntryByResourceIdAsync() in gdata_file_system.cc BUG=143517 TEST=out/Release/unit_tests --gtest_filter='GDataDirectoryServiceTest.*' Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=152397

Patch Set 1 #

Total comments: 4

Patch Set 2 : rebase #

Patch Set 3 : address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -2 lines) Patch
M chrome/browser/chromeos/gdata/gdata_directory_service.h View 1 2 2 chunks +14 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/gdata/gdata_directory_service.cc View 1 chunk +23 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/gdata/gdata_directory_service_unittest.cc View 1 chunk +31 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
satorux1
8 years, 4 months ago (2012-08-20 18:47:50 UTC) #1
achuithb
lgtm https://chromiumcodereview.appspot.com/10861015/diff/1/chrome/browser/chromeos/gdata/gdata_directory_service.h File chrome/browser/chromeos/gdata/gdata_directory_service.h (right): https://chromiumcodereview.appspot.com/10861015/diff/1/chrome/browser/chromeos/gdata/gdata_directory_service.h#newcode191 chrome/browser/chromeos/gdata/gdata_directory_service.h:191: // TODO(achuith): Get rid of this in favor ...
8 years, 4 months ago (2012-08-20 18:53:30 UTC) #2
satorux1
http://codereview.chromium.org/10861015/diff/1/chrome/browser/chromeos/gdata/gdata_directory_service.h File chrome/browser/chromeos/gdata/gdata_directory_service.h (right): http://codereview.chromium.org/10861015/diff/1/chrome/browser/chromeos/gdata/gdata_directory_service.h#newcode191 chrome/browser/chromeos/gdata/gdata_directory_service.h:191: // TODO(achuith): Get rid of this in favor of ...
8 years, 4 months ago (2012-08-20 19:07:20 UTC) #3
commit-bot: I haz the power
8 years, 4 months ago (2012-08-20 22:09:38 UTC) #4

Powered by Google App Engine
This is Rietveld 408576698