gdata: Add GDataDirectoryService::GetEntryInfoByResourceId()

gdata: Add GDataDirectoryService::GetEntryInfoByResourceId()

Similar to GDataDirectoryService::GetEntryByResourceIdAsync() but this
one returns a proto instead of GDataEntry*.  This function will be used to
replace use of GDataDirectoryService::GetEntryByResourceIdAsync() in
gdata_file_system.cc

BUG=143517
TEST=out/Release/unit_tests --gtest_filter='GDataDirectoryServiceTest.*'

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=152397

[achuithb, 2012-08-20 18:53:30]

lgtm

https://chromiumcodereview.appspot.com/10861015/diff/1/chrome/browser/chromeo...
File chrome/browser/chromeos/gdata/gdata_directory_service.h (right):

https://chromiumcodereview.appspot.com/10861015/diff/1/chrome/browser/chromeo...
chrome/browser/chromeos/gdata/gdata_directory_service.h:191: // TODO(achuith):
Get rid of this in favor of async version crbug.com/13957.
Can we update this comment to say we want to get rid of this in favor of
GetEntryInfoByResourceId?

https://chromiumcodereview.appspot.com/10861015/diff/1/chrome/browser/chromeo...
chrome/browser/chromeos/gdata/gdata_directory_service.h:195: // |resource_id|.
TODO(achuith): Rename this to GetEntryByResourceId.
Can we update this comment to say we want to get rid of this in favor of
GetEntryInfoByResourceId?

[satorux1, 2012-08-20 19:07:20]

http://codereview.chromium.org/10861015/diff/1/chrome/browser/chromeos/gdata/...
File chrome/browser/chromeos/gdata/gdata_directory_service.h (right):

http://codereview.chromium.org/10861015/diff/1/chrome/browser/chromeos/gdata/...
chrome/browser/chromeos/gdata/gdata_directory_service.h:191: // TODO(achuith):
Get rid of this in favor of async version crbug.com/13957.
On 2012/08/20 18:53:31, achuith.bhandarkar wrote:
> Can we update this comment to say we want to get rid of this in favor of
> GetEntryInfoByResourceId?

Done, but this one is tricky as it's used in processing the feeds synchronously.
See crbug.com/137374. Updated the comment accordingly.

http://codereview.chromium.org/10861015/diff/1/chrome/browser/chromeos/gdata/...
chrome/browser/chromeos/gdata/gdata_directory_service.h:195: // |resource_id|.
TODO(achuith): Rename this to GetEntryByResourceId.
On 2012/08/20 18:53:31, achuith.bhandarkar wrote:
> Can we update this comment to say we want to get rid of this in favor of
> GetEntryInfoByResourceId?

Done.

[commit-bot: I haz the power, 2012-08-20 22:09:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/satorux@chromium.org/10861015/4002