SPDY - A histogram to track spdy versions negotiated by chrome.

net/socket/next_proto.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_SOCKET_NEXT_PROTO_H_
 #define NET_SOCKET_NEXT_PROTO_H_
 
 namespace net {
 
 // Next Protocol Negotiation (NPN), if successful, results in agreement on an
 // application-level string that specifies the application level protocol to
 // use over the TLS connection. NextProto enumerates the application level
 // protocols that we recognise.
 enum NextProto {
   kProtoUnknown = 0,
   kProtoHTTP11 = 1,
   kProtoSPDY1 = 2,
   kProtoSPDY2 = 3,
   kProtoSPDY3 = 5,

[jar (doing other things), 2012/08/21 22:52:12]

Why did you skip 4?  If it is being used for something, it would be clearer to
include it here, with a name that explains what it was used for.

[ramant (doing other things), 2012/08/21 23:59:37]

It was used for spdy/2.1.

Added it back. Uses of spdy21 was deleted.

Done.

+  kProtoMaximumVersion = 99,

[jar (doing other things), 2012/08/21 22:52:12]

So lang as kProtoMaximumVersion is larger than any existing versions (by 10, you
can always go and add more enums (and not have problem with conflation).

I'd suggest setting it to 6 rather than 99 today.... and upping it as we support
larger version numbers.

[ramant (doing other things), 2012/08/21 23:59:37]

Done.

 };
 
 }  // namespace net
 
 #endif  // NET_SOCKET_NEXT_PROTO_H_