SPDY - A histogram to track spdy versions negotiated by chrome.

SPDY - A histogram to track spdy versions negotiated by chrome.

BUG=143965
TEST=network unittests. In about:histograms, we would see Net.SpdyVersion histogram
R=jar
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=152855

[ramant (doing other things), 2012-08-21 18:37:09]

Hi Jim,
  Will add new histogram to histograms.xml. Will add the new enums. Added a very
high number for number of SPDY versions (because we could have versions like
SPDY/2.1 ...).

thanks
raman

[jar (doing other things), 2012-08-21 22:52:12]

https://chromiumcodereview.appspot.com/10860073/diff/1/net/socket/next_proto.h
File net/socket/next_proto.h (right):

https://chromiumcodereview.appspot.com/10860073/diff/1/net/socket/next_proto....
net/socket/next_proto.h:19: kProtoSPDY3 = 5,
Why did you skip 4?  If it is being used for something, it would be clearer to
include it here, with a name that explains what it was used for.

https://chromiumcodereview.appspot.com/10860073/diff/1/net/socket/next_proto....
net/socket/next_proto.h:20: kProtoMaximumVersion = 99,
So lang as kProtoMaximumVersion is larger than any existing versions (by 10, you
can always go and add more enums (and not have problem with conflation).

I'd suggest setting it to 6 rather than 99 today.... and upping it as we support
larger version numbers.

[ramant (doing other things), 2012-08-21 23:59:37]

https://chromiumcodereview.appspot.com/10860073/diff/1/net/socket/next_proto.h
File net/socket/next_proto.h (right):

https://chromiumcodereview.appspot.com/10860073/diff/1/net/socket/next_proto....
net/socket/next_proto.h:19: kProtoSPDY3 = 5,
On 2012/08/21 22:52:12, jar wrote:
> Why did you skip 4?  If it is being used for something, it would be clearer to
> include it here, with a name that explains what it was used for.

It was used for spdy/2.1.

Added it back. Uses of spdy21 was deleted.

Done.

https://chromiumcodereview.appspot.com/10860073/diff/1/net/socket/next_proto....
net/socket/next_proto.h:20: kProtoMaximumVersion = 99,
On 2012/08/21 22:52:12, jar wrote:
> So lang as kProtoMaximumVersion is larger than any existing versions (by 10,
you
> can always go and add more enums (and not have problem with conflation).
> 
> I'd suggest setting it to 6 rather than 99 today.... and upping it as we
support
> larger version numbers.

Done.

[jar (doing other things), 2012-08-22 01:16:28]

lgtm

[commit-bot: I haz the power, 2012-08-22 01:20:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rtenneti@chromium.org/10860073/8001

[commit-bot: I haz the power, 2012-08-22 02:54:23]

Try job failure for 10860073-8001 (retry) on win for step "compile" (clobber
build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number...

[commit-bot: I haz the power, 2012-08-22 05:30:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rtenneti@chromium.org/10860073/8001

[commit-bot: I haz the power, 2012-08-22 05:47:31]

Try job failure for 10860073-8001 on linux_clang for step "update".
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_clan...

Step "update" is always a major failure.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2012-08-22 18:27:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rtenneti@chromium.org/10860073/18005

[commit-bot: I haz the power, 2012-08-22 20:02:31]

Try job failure for 10860073-18005 (retry) on win for step "compile" (clobber
build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number...

[cbentzel, 2012-08-22 20:23:35]

Thanks for doing this quickly.

LGTM

On Tue, Aug 21, 2012 at 9:16 PM, <jar@chromium.org> wrote:

> lgtm
>
>
>
>
https://chromiumcodereview.**appspot.com/10860073/<https://chromiumcodereview...
>