Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Unified Diff: chrome/browser/autocomplete/search_provider.h

Issue 10860068: Fix Omnibox search provider's confusing internal variable semantics (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/autocomplete/search_provider.h
diff --git a/chrome/browser/autocomplete/search_provider.h b/chrome/browser/autocomplete/search_provider.h
index 50631579c5f06660607687e6e643e86361431ce1..1885f2dd9f2f24e94320e96b18f593ded6c2e21c 100644
--- a/chrome/browser/autocomplete/search_provider.h
+++ b/chrome/browser/autocomplete/search_provider.h
@@ -335,8 +335,12 @@ class SearchProvider : public AutocompleteProvider,
HistoryResults keyword_history_results_;
HistoryResults default_history_results_;
+ // Indicates that |timer_| is still running. When it triggers, we'll
+ // send requests to the suggest server.
+ bool in_timer_phase_;
msw 2012/08/21 18:30:27 Remove this.
Mark P 2012/08/21 19:13:41 Done.
+
// Number of suggest results that haven't yet arrived. If greater than 0 it
- // indicates either |timer_| or one of the URLFetchers is still running.
+ // indicates one of the URLFetchers is still running.
int suggest_results_pending_;
// A timer to start a query to the suggest server after the user has stopped
« no previous file with comments | « no previous file | chrome/browser/autocomplete/search_provider.cc » ('j') | chrome/browser/autocomplete/search_provider.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698