chrome/browser/autocomplete/search_provider.h - Issue 10860068: Fix Omnibox search provider's confusing internal variable semantics

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/autocomplete/search_provider.h

Issue 10860068: Fix Omnibox search provider's confusing internal variable semantics (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/autocomplete/search_provider.h

diff --git a/chrome/browser/autocomplete/search_provider.h b/chrome/browser/autocomplete/search_provider.h

index 50631579c5f06660607687e6e643e86361431ce1..1885f2dd9f2f24e94320e96b18f593ded6c2e21c 100644

--- a/chrome/browser/autocomplete/search_provider.h

+++ b/chrome/browser/autocomplete/search_provider.h

@@ -335,8 +335,12 @@ class SearchProvider : public AutocompleteProvider,

HistoryResults keyword_history_results_;

HistoryResults default_history_results_;

+ // Indicates that |timer_| is still running. When it triggers, we'll

+ // send requests to the suggest server.

+ bool in_timer_phase_;

msw 2012/08/21 17:12:28 Why not remove this and just use timer_.IsRunning(

Mark P 2012/08/21 17:47:51 No reason why not. I didn't know there was that i

// Number of suggest results that haven't yet arrived. If greater than 0 it

- // indicates either |timer_| or one of the URLFetchers is still running.

+ // indicates one of the URLFetchers is still running.

int suggest_results_pending_;

// A timer to start a query to the suggest server after the user has stopped

« no previous file with comments | « no previous file | chrome/browser/autocomplete/search_provider.cc » ('j') | no next file with comments »