Fix Omnibox search provider's confusing internal variable semantics

chrome/browser/autocomplete/search_provider.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // This file contains the Search autocomplete provider.  This provider is
 // responsible for all non-keyword autocomplete entries that start with
 // "Search <engine> for ...", including searching for the current input string,
 // search history, and search suggestions.  An instance of it gets created and
 // managed by the autocomplete controller.
 
@@ skipping 317 matching lines @@
   // The user's input.
   AutocompleteInput input_;
 
   // Input text when searching against the keyword provider.
   string16 keyword_input_text_;
 
   // Searches in the user's history that begin with the input text.
   HistoryResults keyword_history_results_;
   HistoryResults default_history_results_;
 
+  // Indicates that |timer_| is still running.  When it triggers, we'll
+  // send requests to the suggest server.
+  bool in_timer_phase_;

[msw, 2012/08/21 18:30:27]

Remove this.

[Mark P, 2012/08/21 19:13:41]

Done.

+
   // Number of suggest results that haven't yet arrived. If greater than 0 it
-  // indicates either |timer_| or one of the URLFetchers is still running.
+  // indicates one of the URLFetchers is still running.
   int suggest_results_pending_;
 
   // A timer to start a query to the suggest server after the user has stopped
   // typing for long enough.
   base::OneShotTimer<SearchProvider> timer_;
 
   // The suggest field trial group number that we are in.  This will be
   // removed later after the suggest delay experiments are removed.
   int suggest_field_trial_group_number_;
 
@@ skipping 25 matching lines @@
   // Has FinalizeInstantQuery been invoked since the last |Start|?
   bool instant_finalized_;
 
   // The |suggest_text| parameter passed to FinalizeInstantQuery.
   string16 default_provider_suggest_text_;
 
   DISALLOW_COPY_AND_ASSIGN(SearchProvider);
 };
 
 #endif  // CHROME_BROWSER_AUTOCOMPLETE_SEARCH_PROVIDER_H_