Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(807)

Unified Diff: lib/html/doc/interface/HttpRequest.dartdoc

Issue 10860050: Update XMLHttpRequest documentation. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | lib/html/doc/interface/HttpRequestException.dartdoc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/html/doc/interface/HttpRequest.dartdoc
===================================================================
--- lib/html/doc/interface/HttpRequest.dartdoc (revision 11000)
+++ lib/html/doc/interface/HttpRequest.dartdoc (working copy)
@@ -6,18 +6,22 @@
// This file contains documentation that is merged into the real source.
// Do not make code changes here.
+/**
+ * HttpRequest is Dart's name for the XMLHttpRequest object, as described below.
sethladd 2012/08/20 21:36:20 How about a few sentences about what this class is
Emily Fortuna 2012/08/20 21:40:15 So if you look at the current page, it looks like
sethladd 2012/08/20 21:43:32 Oh, neat! Didn't realize we supported both.
+ */
+
/// @domName XMLHttpRequest
-interface XMLHttpRequest extends EventTarget default _XMLHttpRequestFactoryProvider {
+interface HttpRequest extends EventTarget default _XMLHttpRequestFactoryProvider {
// TODO(rnystrom): This name should just be "get" which is valid in Dart, but
// not correctly implemented yet. (b/4970173)
- XMLHttpRequest.get(String url, onSuccess(XMLHttpRequest request));
+ HttpRequest.get(String url, onSuccess(HttpRequest request));
- XMLHttpRequest();
+ HttpRequest();
/**
* @domName EventTarget.addEventListener, EventTarget.removeEventListener, EventTarget.dispatchEvent
*/
- XMLHttpRequestEvents get on();
+ HttpRequestEvents get on();
static final int DONE = 4;
@@ -48,7 +52,7 @@
String responseType;
/** @domName XMLHttpRequest.responseXML */
- final Document responseXML;
+ final Document responseXML; /*TODO(efortuna): rename, too?*/
sra1 2012/08/20 21:38:33 No rename. The response can be many things, inclu
/** @domName XMLHttpRequest.status */
final int status;
@@ -57,7 +61,7 @@
final String statusText;
/** @domName XMLHttpRequest.upload */
- final XMLHttpRequestUpload upload;
+ final ttpRequestUpload upload;
sethladd 2012/08/20 21:36:20 I think you mean RequestUpload here?
sra1 2012/08/20 21:38:33 Typo HttpRequestUpload.
Emily Fortuna 2012/08/20 21:40:15 Oops! I meant HttpRequestUpload.
/** @domName XMLHttpRequest.withCredentials */
bool withCredentials;
@@ -93,7 +97,7 @@
void setRequestHeader(String header, String value);
}
-interface XMLHttpRequestEvents extends Events {
+interface HttpRequestEvents extends Events {
EventListenerList get abort();
« no previous file with comments | « no previous file | lib/html/doc/interface/HttpRequestException.dartdoc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698