Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 10860044: 1st CL in a series to remove PluginGroup. Updates PluginList. (Closed)

Created:
8 years, 4 months ago by ibraaaa
Modified:
8 years, 4 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews, darin-cc_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

1st CL in a series to remove PluginGroup. Updates PluginList. This is the first CL in a series that aims at removing PluginGroup class and moving harded coded group definition data to .json config files. This CL updates PluginList class with new methods not relying on PluginGroup class, these methods are to be called by upper layer methods instead of PluginGroup dependent methods. Changes in upper layer will be introduced in upcoming CLs. The last CL in the series should remove PluginGroup class and all its dependencies. BUG=124396 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=152399

Patch Set 1 #

Total comments: 6

Patch Set 2 : 1st CL in series to delete PluginGroup and move hardcoded definitions to .json config #

Patch Set 3 : 1st CL in series to delete PluginGroup. Updates PluginList only. #

Patch Set 4 : 1st CL in series to delete PluginGroup. Updates PluginList only. #

Patch Set 5 : 1st CL in series to delete PluginGroup. Updates PluginList only. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+299 lines, -39 lines) Patch
M webkit/plugins/npapi/mock_plugin_list.h View 1 1 chunk +5 lines, -0 lines 0 comments Download
M webkit/plugins/npapi/mock_plugin_list.cc View 1 1 chunk +8 lines, -0 lines 0 comments Download
M webkit/plugins/npapi/plugin_list.h View 1 8 chunks +36 lines, -0 lines 0 comments Download
M webkit/plugins/npapi/plugin_list.cc View 1 17 chunks +110 lines, -37 lines 0 comments Download
M webkit/plugins/npapi/plugin_list_mac.mm View 1 1 chunk +7 lines, -0 lines 0 comments Download
M webkit/plugins/npapi/plugin_list_posix.cc View 1 2 chunks +31 lines, -0 lines 0 comments Download
M webkit/plugins/npapi/plugin_list_win.cc View 1 2 3 4 2 chunks +102 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
ibraaaa
This CL updates PluginList class only. For all methods with signature taking a PluginGroup, another ...
8 years, 4 months ago (2012-08-20 17:09:50 UTC) #1
Bernhard Bauer
Looks very good generally, just some nits below, and with the CL description: * Could ...
8 years, 4 months ago (2012-08-20 17:22:42 UTC) #2
ibraaaa
Done, PTAL. https://chromiumcodereview.appspot.com/10860044/diff/1/webkit/plugins/npapi/plugin_list.cc File webkit/plugins/npapi/plugin_list.cc (right): https://chromiumcodereview.appspot.com/10860044/diff/1/webkit/plugins/npapi/plugin_list.cc#newcode368 webkit/plugins/npapi/plugin_list.cc:368: ScopedVector<PluginGroup> new_plugin_groups; // TODO(ibraaaa): DELETE On 2012/08/20 ...
8 years, 4 months ago (2012-08-20 18:05:28 UTC) #3
Bernhard Bauer
LGTM!
8 years, 4 months ago (2012-08-20 18:15:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ibraaaa@google.com/10860044/10
8 years, 4 months ago (2012-08-20 18:15:42 UTC) #5
commit-bot: I haz the power
Presubmit check for 10860044-10 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 4 months ago (2012-08-20 18:15:49 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ibraaaa@google.com/10860044/8002
8 years, 4 months ago (2012-08-20 18:24:24 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ibraaaa@google.com/10860044/3004
8 years, 4 months ago (2012-08-20 18:48:12 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ibraaaa@google.com/10860044/2005
8 years, 4 months ago (2012-08-20 19:08:38 UTC) #9
commit-bot: I haz the power
8 years, 4 months ago (2012-08-20 22:14:09 UTC) #10
Change committed as 152399

Powered by Google App Engine
This is Rietveld 408576698