Issue 10860037: [content shell] rename layout_test_controller{,_host,_bindings}.* to webkit_test_runner

Issue 10860037: [content shell] rename layout_test_controller{,_host,_bindings}.* to webkit_test_runner (Closed)

Created:
8 years, 4 months ago by jochen (gone - plz use gerrit)

Modified:
8 years, 4 months ago

Reviewers:
jam, marja

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[content shell] rename layout_test_controller{,_host,_bindings}.* to webkit_test_runner BUG=111316 TEST=none TBR=jam@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=152311

Patch Set 2 : patch for landing #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+86 lines, -881 lines)			Patch
M	content/content_shell.gypi	View		2 chunks	+6 lines, -6 lines	0 comments	Download
D	content/shell/layout_test_controller.h	View		1 chunk	+0 lines, -33 lines	0 comments	Download
D	content/shell/layout_test_controller.cc	View		1 chunk	+0 lines, -220 lines	0 comments	Download
D	content/shell/layout_test_controller.js	View		1 chunk	+0 lines, -63 lines	0 comments	Download
D	content/shell/layout_test_controller_bindings.h	View		1 chunk	+0 lines, -29 lines	0 comments	Download
D	content/shell/layout_test_controller_bindings.cc	View		1 chunk	+0 lines, -156 lines	0 comments	Download
D	content/shell/layout_test_controller_host.h	View		1 chunk	+0 lines, -74 lines	0 comments	Download
D	content/shell/layout_test_controller_host.cc	View		1 chunk	+0 lines, -220 lines	0 comments	Download
M	content/shell/shell_browser_main.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	content/shell/shell_content_browser_client.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	content/shell/shell_content_renderer_client.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	content/shell/shell_javascript_dialog_creator.cc	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	content/shell/shell_render_process_observer.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	content/shell/shell_resources.grd	View		1 chunk	+1 line, -1 line	0 comments	Download
A +	content/shell/webkit_test_runner.h	View		2 chunks	+8 lines, -8 lines	0 comments	Download
A +	content/shell/webkit_test_runner.cc	View		4 chunks	+9 lines, -9 lines	0 comments	Download
A +	content/shell/webkit_test_runner.js	View	1	2 chunks	+3 lines, -3 lines	0 comments	Download
A +	content/shell/webkit_test_runner_bindings.h	View		2 chunks	+7 lines, -7 lines	0 comments	Download
A +	content/shell/webkit_test_runner_bindings.cc	View		2 chunks	+7 lines, -7 lines	0 comments	Download
A +	content/shell/webkit_test_runner_host.h	View		4 chunks	+10 lines, -10 lines	0 comments	Download
A +	content/shell/webkit_test_runner_host.cc	View		9 chunks	+24 lines, -24 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

marja

lgtm modulo comment https://chromiumcodereview.appspot.com/10860037/diff/1/content/shell/webkit_test_runner.js File content/shell/webkit_test_runner.js (left): https://chromiumcodereview.appspot.com/10860037/diff/1/content/shell/webkit_test_runner.js#oldcode49 content/shell/webkit_test_runner.js:49: AccessibilityController.prototype = DefaultHandler("accessibilityController"); You could add ...

8 years, 4 months ago (2012-08-20 09:07:37 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/10860037/7002

8 years, 4 months ago (2012-08-20 09:10:56 UTC) #4

commit-bot: I haz the power

8 years, 4 months ago (2012-08-20 10:44:29 UTC) #5

Try job failure for 10860037-7002 (retry) on linux_rel for step
"interactive_ui_tests".
It's a second try, previously, step "interactive_ui_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

Expand Messages | Collapse Messages