Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Unified Diff: remoting/protocol/input_filter_unittest.cc

Issue 10860033: Allow input & clipboard filters to be disabled without NULLing target stub. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address review comments and fix clipboard pipeline initialization. Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/protocol/input_filter.cc ('k') | remoting/remoting.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/protocol/input_filter_unittest.cc
diff --git a/remoting/protocol/input_filter_unittest.cc b/remoting/protocol/input_filter_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..97db37d135d76af4a1dcdb08a92e836ad316fcc2
--- /dev/null
+++ b/remoting/protocol/input_filter_unittest.cc
@@ -0,0 +1,82 @@
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "remoting/protocol/input_filter.h"
+
+#include "remoting/proto/event.pb.h"
+#include "remoting/protocol/protocol_mock_objects.h"
+#include "testing/gmock/include/gmock/gmock.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+using ::testing::_;
+
+namespace remoting {
+namespace protocol {
+
+MATCHER_P2(EqualsKeyEvent, usb_keycode, pressed, "") {
+ return arg.usb_keycode() == static_cast<uint32>(usb_keycode) &&
+ arg.pressed() == pressed;
+}
+
+MATCHER_P2(EqualsMouseMoveEvent, x, y, "") {
+ return arg.x() == x && arg.y() == y;
+}
+
+static KeyEvent NewKeyEvent(uint32 usb_keycode, bool pressed) {
+ KeyEvent event;
+ event.set_usb_keycode(usb_keycode);
+ event.set_pressed(pressed);
+ return event;
+}
+
+static MouseEvent MouseMoveEvent(int x, int y) {
+ MouseEvent event;
+ event.set_x(x);
+ event.set_y(y);
+ return event;
+}
+
+static void InjectTestSequence(protocol::InputStub* input_stub) {
+ // Inject a key event.
+ input_stub->InjectKeyEvent(NewKeyEvent(0, true));
+ input_stub->InjectKeyEvent(NewKeyEvent(0, false));
+
+ // Inject mouse movemement.
+ input_stub->InjectMouseEvent(MouseMoveEvent(10, 20));
+}
+
+// Verify that the filter passes events on correctly to a configured stub.
+TEST(InputFilterTest, EventsPassThroughFilter) {
+ MockInputStub input_stub;
+ InputFilter input_filter(&input_stub);
+
+ EXPECT_CALL(input_stub, InjectKeyEvent(EqualsKeyEvent(0, true)));
+ EXPECT_CALL(input_stub, InjectKeyEvent(EqualsKeyEvent(0, false)));
+ EXPECT_CALL(input_stub, InjectMouseEvent(EqualsMouseMoveEvent(10, 20)));
+
+ InjectTestSequence(&input_filter);
+}
+
+// Verify that the filter ignores events if disabled.
+TEST(InputFilterTest, IgnoreEventsIfDisabled) {
+ MockInputStub input_stub;
+ InputFilter input_filter(&input_stub);
+
+ input_filter.set_enabled(false);
+
+ EXPECT_CALL(input_stub, InjectKeyEvent(_)).Times(0);
+ EXPECT_CALL(input_stub, InjectMouseEvent(_)).Times(0);
+
+ InjectTestSequence(&input_filter);
+}
+
+// Verify that the filter ignores events if not configured.
+TEST(InputFilterTest, IgnoreEventsIfNotConfigured) {
+ InputFilter input_filter;
+
+ InjectTestSequence(&input_filter);
+}
+
+} // namespace protocol
+} // namespace remoting
« no previous file with comments | « remoting/protocol/input_filter.cc ('k') | remoting/remoting.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698