Allow input & clipboard filters to be disabled without NULLing target stub.

Allow input & clipboard filters to be disabled without NULLing target stub.

This CL also:
* Adds unit tests for InputFilter and CLipboardFilter.
* Updates ClientSession to enabled/disable filters for authentication.

BUG=118511
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=152418

[Wez, 2012-08-18 22:19:38]

PTAL

[simonmorris, 2012-08-20 16:37:18]

lgtm with optional suggestions

http://codereview.chromium.org/10860033/diff/1/remoting/host/client_session.cc
File remoting/host/client_session.cc (right):

http://codereview.chromium.org/10860033/diff/1/remoting/host/client_session.c...
remoting/host/client_session.cc:48: // |auth_input_filter|'s state reflects
whether the session is authenticated.
_ after "auth_input_filter".

http://codereview.chromium.org/10860033/diff/1/remoting/protocol/clipboard_fi...
File remoting/protocol/clipboard_filter.h (right):

http://codereview.chromium.org/10860033/diff/1/remoting/protocol/clipboard_fi...
remoting/protocol/clipboard_filter.h:16: // NULL. Event forwarding may be
disabled independently of the configured
"iff" doesn't apply now.

Is it feasible to require that clipboard_stub be non-NULL?

http://codereview.chromium.org/10860033/diff/1/remoting/protocol/input_filter.h
File remoting/protocol/input_filter.h (right):

http://codereview.chromium.org/10860033/diff/1/remoting/protocol/input_filter...
remoting/protocol/input_filter.h:15: // Forwards input events to |input_stub|,
iif |input_stub| is not NULL.
"iff" doesn't apply now.

Is it feasible to require input_stub to be non-NULL?

[Wez, 2012-08-20 19:58:20]

FYI

http://codereview.chromium.org/10860033/diff/1/remoting/host/client_session.cc
File remoting/host/client_session.cc (right):

http://codereview.chromium.org/10860033/diff/1/remoting/host/client_session.c...
remoting/host/client_session.cc:48: // |auth_input_filter|'s state reflects
whether the session is authenticated.
On 2012/08/20 16:37:18, simonmorris wrote:
> _ after "auth_input_filter".

Done.

http://codereview.chromium.org/10860033/diff/1/remoting/protocol/clipboard_fi...
File remoting/protocol/clipboard_filter.h (right):

http://codereview.chromium.org/10860033/diff/1/remoting/protocol/clipboard_fi...
remoting/protocol/clipboard_filter.h:16: // NULL. Event forwarding may be
disabled independently of the configured
On 2012/08/20 16:37:18, simonmorris wrote:
> "iff" doesn't apply now.
> 
> Is it feasible to require that clipboard_stub be non-NULL?

We could certainly [D]CHECK() that the stub is non-NULL if we process an event
while the filter is not disabled.  That will complicate code that just wants to
process events if there is a target stub and not process them until then, i.e.
for which the set_stub(NULL/non-NULL) arrangement is more natural, so I'm
inclined to leave things as they are.

http://codereview.chromium.org/10860033/diff/1/remoting/protocol/input_filter.h
File remoting/protocol/input_filter.h (right):

http://codereview.chromium.org/10860033/diff/1/remoting/protocol/input_filter...
remoting/protocol/input_filter.h:15: // Forwards input events to |input_stub|,
iif |input_stub| is not NULL.
On 2012/08/20 16:37:18, simonmorris wrote:
> "iff" doesn't apply now.
> 
> Is it feasible to require input_stub to be non-NULL?

Done.

[commit-bot: I haz the power, 2012-08-20 19:58:30]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/wez@chromium.org/10860033/13

[commit-bot: I haz the power, 2012-08-20 22:52:42]

Change committed as 152418