Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8974)

Unified Diff: chrome/common/pref_names.cc

Issue 10860025: Remove promotion-type-specific JSON handling from NotificationPromo (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Indent in contructor. Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/pref_names.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/pref_names.cc
diff --git a/chrome/common/pref_names.cc b/chrome/common/pref_names.cc
index ff25e2ebce96cdfe2dd16f2c0fe1a78d712dcf06..820df71d4f7ed644684b82866829a87164569205 100644
--- a/chrome/common/pref_names.cc
+++ b/chrome/common/pref_names.cc
@@ -1479,61 +1479,6 @@ const char kNtpPromoVersion[] = "ntp.promo_version";
// The last locale the promo was fetched for.
const char kNtpPromoLocale[] = "ntp.promo_locale";
-// Whether promo should be shown to Dev builds, Beta and Dev, or all builds.
-const char kNtpPromoBuild[] = "ntp.promo_build";
-
-// True if user has explicitly closed the promo line.
-const char kNtpPromoClosed[] = "ntp.promo_closed";
-
-// Users are randomly divided into 100 groups in order to slowly roll out
-// special promos.
-const char kNtpPromoGroup[] = "ntp.promo_group";
-
-// Number of promo groups (buckets).
-const char kNtpPromoNumGroups[] = "ntp.promo_num_groups";
-
-// Initial segment of the groups to show the promo to.
-const char kNtpPromoInitialSegment[] = "ntp.promo_initial_segment";
-
-// Number of additional segments to show this promo to every time slice.
-const char kNtpPromoIncrement[] = "ntp.promo_increment";
-
-// Amount of time each promo group should be shown a promo that is being slowly
-// rolled out, in seconds.
-const char kNtpPromoGroupTimeSlice[] = "ntp.promo_group_timeslice";
-
-// Number of groups to roll out this promo to.
-const char kNtpPromoGroupMax[] = "ntp.promo_group_max";
-
-// Number of views of this promo.
-const char kNtpPromoViews[] = "ntp.promo_views";
-
-// Max number of views of this promo.
-const char kNtpPromoViewsMax[] = "ntp.promo_views_max";
-
-// Target platform for this promo.
-const char kNtpPromoPlatform[] = "ntp.promo_platform";
-
-// Promo line from server.
-const char kNtpPromoLine[] = "ntp.promo_line";
-
-#if defined(OS_ANDROID)
-// Promo line from server (long).
-const char kNtpPromoLineLong[] = "ntp.promo_line_long";
-// Promo action that needs to be triggered
-const char kNtpPromoActionType[] = "ntp.promo_action_type";
-// Promo action arguments
-const char kNtpPromoActionArgs[] = "ntp.promo_action_args";
-#endif // defined(OS_ANDROID)
-
-// Dates between which the NTP should show a promotional line downloaded
-// from the promo server.
-const char kNtpPromoStart[] = "ntp.promo_start";
-const char kNtpPromoEnd[] = "ntp.promo_end";
-
-// True if this promo should only be shown to G+ users.
-const char kNtpPromoGplusRequired[] = "ntp.gplus_required";
-
// Boolean indicating whether the web store is active for the current locale.
const char kNtpWebStoreEnabled[] = "ntp.webstore_enabled";
« no previous file with comments | « chrome/common/pref_names.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698