Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2243)

Unified Diff: chrome/browser/web_resource/notification_promo.h

Issue 10860025: Remove promotion-type-specific JSON handling from NotificationPromo (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Indent in contructor. Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/web_resource/notification_promo.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/web_resource/notification_promo.h
diff --git a/chrome/browser/web_resource/notification_promo.h b/chrome/browser/web_resource/notification_promo.h
index e46da99b350cdaaee0b8052da8c314edc8644a68..9cc075e9c8c8739fe1d2daab3b9909a87f08cfc0 100644
--- a/chrome/browser/web_resource/notification_promo.h
+++ b/chrome/browser/web_resource/notification_promo.h
@@ -59,13 +59,10 @@ class NotificationPromo {
bool new_notification() const { return new_notification_; }
const std::string& promo_text() const { return promo_text_; }
-#if defined(OS_ANDROID) || defined(OS_IOS)
- const std::string& promo_text_long() const { return promo_text_long_; }
- const std::string& promo_action_type() const { return promo_action_type_; }
- const base::ListValue* promo_action_args() const {
- return promo_action_args_.get();
+ PromoType promo_type() const { return promo_type_; }
+ const base::DictionaryValue* promo_payload() const {
+ return promo_payload_.get();
}
-#endif // defined(OS_ANDROID) || defined(OS_IOS)
// Register preferences.
static void RegisterUserPrefs(PrefService* prefs);
@@ -100,11 +97,9 @@ class NotificationPromo {
PromoType promo_type_;
std::string promo_text_;
-#if defined(OS_ANDROID) || defined(OS_IOS)
- std::string promo_text_long_;
- std::string promo_action_type_;
- scoped_ptr<base::ListValue> promo_action_args_;
-#endif // defined(OS_ANDROID) || defined(OS_IOS)
+
+ // Note that promo_payload_ isn't currently used for desktop promos.
+ scoped_ptr<const base::DictionaryValue> promo_payload_;
double start_;
double end_;
« no previous file with comments | « no previous file | chrome/browser/web_resource/notification_promo.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698