Remove promotion-type-specific JSON handling from NotificationPromo

chrome/browser/web_resource/notification_promo.h

Index: chrome/browser/web_resource/notification_promo.h
diff --git a/chrome/browser/web_resource/notification_promo.h b/chrome/browser/web_resource/notification_promo.h
index e46da99b350cdaaee0b8052da8c314edc8644a68..a15958592624b48e0f2d57545709a3f830adef05 100644
--- a/chrome/browser/web_resource/notification_promo.h
+++ b/chrome/browser/web_resource/notification_promo.h
@@ -59,13 +59,10 @@ class NotificationPromo {
   bool new_notification() const { return new_notification_; }
 
   const std::string& promo_text() const { return promo_text_; }
-#if defined(OS_ANDROID) || defined(OS_IOS)
-  const std::string& promo_text_long() const { return promo_text_long_; }
-  const std::string& promo_action_type() const { return promo_action_type_; }
-  const base::ListValue* promo_action_args() const {
-    return promo_action_args_.get();
+  PromoType promo_type() const { return promo_type_; }
+  const base::DictionaryValue* promo_payload() const {
+    return promo_payload_.get();
   }
-#endif  // defined(OS_ANDROID) || defined(OS_IOS)
 
   // Register preferences.
   static void RegisterUserPrefs(PrefService* prefs);
@@ -100,11 +97,8 @@ class NotificationPromo {
 
   PromoType promo_type_;
   std::string promo_text_;
-#if defined(OS_ANDROID) || defined(OS_IOS)
-  std::string promo_text_long_;
-  std::string promo_action_type_;
-  scoped_ptr<base::ListValue> promo_action_args_;
-#endif  // defined(OS_ANDROID) || defined(OS_IOS)
+  // Note that |payload| isn't currently used for desktop promos.

[achuithb, 2012/08/22 19:49:20]

promo_payload_. You should probably drop promo_. I don't think we use |foo|
notation for members, just for function args.

[aruslan, 2012/08/23 00:49:59]

Done -- but I kept it promo_payload as it's one of three visible externally --
promo_text(), promo_type() and promo_payload().

+  scoped_ptr<const base::DictionaryValue> promo_payload_;
 
   double start_;
   double end_;