chrome/chrome_browser.gypi - Issue 10860025: Remove promotion-type-specific JSON handling from NotificationPromo

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/chrome_browser.gypi

Issue 10860025: Remove promotion-type-specific JSON handling from NotificationPromo (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/web_resource/notification_promo_mobile_ntp.cc ('K') | « chrome/browser/web_resource/promo_resource_service_unittest.cc ('k') | chrome/chrome_tests.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/chrome_browser.gypi

diff --git a/chrome/chrome_browser.gypi b/chrome/chrome_browser.gypi

index 54806fa428d224ab9b4a2e71436f13906bb0fa3d..5dca4f2d783371b2728aa563920c170f59b243f2 100644

--- a/chrome/chrome_browser.gypi

+++ b/chrome/chrome_browser.gypi

@@ -4969,6 +4969,7 @@

'sources': [

'browser/ui/webui/ntp/android/partner_bookmarks_shim.cc',

'browser/ui/webui/ntp/android/partner_bookmarks_shim.h',

+ 'browser/web_resource/notification_promo_mobile_ntp.cc',

achuithb 2012/08/17 22:55:12 Is mobile the right name? Not android? Or is this

aruslan 2012/08/20 15:36:53 Very good question! I will add Mihai and Eric to t

'sources!': [

'browser/bookmarks/bookmark_context_menu_controller.cc',