Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(431)

Issue 10860024: Handle updates to the wrapper script. (Closed)

Created:
8 years, 4 months ago by Jamie
Modified:
8 years, 4 months ago
Reviewers:
Lambros
CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, pam+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org
Visibility:
Public.

Description

Handle updates to the wrapper script. BUG=139919 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=152402

Patch Set 1 #

Patch Set 2 : Fixed typo and removed debugging. #

Total comments: 5

Patch Set 3 : Reinstated spin protection. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -28 lines) Patch
M remoting/host/installer/linux/Makefile View 1 chunk +1 line, -3 lines 0 comments Download
M remoting/host/installer/linux/debian/control View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/installer/linux/debian/postinst View 1 1 chunk +32 lines, -1 line 0 comments Download
A remoting/host/installer/linux/debian/preinst View 1 chunk +26 lines, -0 lines 0 comments Download
A + remoting/tools/is_me2me_desktop View 1 chunk +3 lines, -3 lines 0 comments Download
M remoting/tools/me2me_virtual_host.py View 1 2 3 chunks +32 lines, -20 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Jamie
This CL ensures that updates to the wrapper script are handled sensibly. Note that, when ...
8 years, 4 months ago (2012-08-17 22:05:14 UTC) #1
Lambros
http://codereview.chromium.org/10860024/diff/2001/remoting/host/installer/linux/debian/preinst File remoting/host/installer/linux/debian/preinst (right): http://codereview.chromium.org/10860024/diff/2001/remoting/host/installer/linux/debian/preinst#newcode22 remoting/host/installer/linux/debian/preinst:22: save_hash /usr/bin/me2me_virtual_host Should save_hash() the Python modules (keygen.py, gaia_auth.py) ...
8 years, 4 months ago (2012-08-18 00:06:50 UTC) #2
Jamie
ptal https://chromiumcodereview.appspot.com/10860024/diff/2001/remoting/host/installer/linux/debian/preinst File remoting/host/installer/linux/debian/preinst (right): https://chromiumcodereview.appspot.com/10860024/diff/2001/remoting/host/installer/linux/debian/preinst#newcode22 remoting/host/installer/linux/debian/preinst:22: save_hash /usr/bin/me2me_virtual_host On 2012/08/18 00:06:50, Lambros wrote: > ...
8 years, 4 months ago (2012-08-20 19:46:05 UTC) #3
Lambros
8 years, 4 months ago (2012-08-20 21:26:20 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698