Handle updates to the wrapper script.

Handle updates to the wrapper script.

BUG=139919
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=152402

[Jamie, 2012-08-17 22:05:14]

This CL ensures that updates to the wrapper script are handled sensibly.

Note that, when the script relaunches, the log file changes. If you think that's
important, we could probably fix it with a tweak to relaunch_self. However,
since users launching using the web-app won't see the script output, they're not
going to know where the log file is anyway, so I think we have bigger problems
in this area. Perhaps the script could set an environment variable as well as
printing out the filename?

https://chromiumcodereview.appspot.com/10860024/diff/2001/remoting/tools/is_m...
File remoting/tools/is_me2me_desktop (right):

https://chromiumcodereview.appspot.com/10860024/diff/2001/remoting/tools/is_m...
remoting/tools/is_me2me_desktop:1: #!/bin/bash
This is actually a new file. Please review is as such.

[Lambros, 2012-08-18 00:06:50]

http://codereview.chromium.org/10860024/diff/2001/remoting/host/installer/lin...
File remoting/host/installer/linux/debian/preinst (right):

http://codereview.chromium.org/10860024/diff/2001/remoting/host/installer/lin...
remoting/host/installer/linux/debian/preinst:22: save_hash
/usr/bin/me2me_virtual_host
Should save_hash() the Python modules (keygen.py, gaia_auth.py) as well?

http://codereview.chromium.org/10860024/diff/2001/remoting/tools/me2me_virtua...
File remoting/tools/me2me_virtual_host.py (right):

http://codereview.chromium.org/10860024/diff/2001/remoting/tools/me2me_virtua...
remoting/tools/me2me_virtual_host.py:897: relaunch_self()
Unfortunately, calling relaunch_self() here (or above) will mean that we never
hit the time.sleep() below, and will put the system into a CPU spin if the
server or session is mis-configured.

I think you need to remove these two relaunch_self() calls.  Then apply this
logic to the case where desktop and session are both None:

If |last_launch_time| is unset (0):
  this is a first-time launch, so go ahead and launch everything
else:
  sleep a bit, to avoid spinning
  relaunch_self()

You could test this by creating an empty file at
~/.chrome-remote-desktop-session and see if it spins like mad :)

[Jamie, 2012-08-20 19:46:05]

ptal

https://chromiumcodereview.appspot.com/10860024/diff/2001/remoting/host/insta...
File remoting/host/installer/linux/debian/preinst (right):

https://chromiumcodereview.appspot.com/10860024/diff/2001/remoting/host/insta...
remoting/host/installer/linux/debian/preinst:22: save_hash
/usr/bin/me2me_virtual_host
On 2012/08/18 00:06:50, Lambros wrote:
> Should save_hash() the Python modules (keygen.py, gaia_auth.py) as well?

I considered that, but since they're only used when starting a new desktop,
there's no value in asking the user to log out if they change. I'd like to
minimize how often we ask people to log out, since it's disruptive.

https://chromiumcodereview.appspot.com/10860024/diff/2001/remoting/tools/me2m...
File remoting/tools/me2me_virtual_host.py (right):

https://chromiumcodereview.appspot.com/10860024/diff/2001/remoting/tools/me2m...
remoting/tools/me2me_virtual_host.py:897: relaunch_self()
On 2012/08/18 00:06:50, Lambros wrote:
> Unfortunately, calling relaunch_self() here (or above) will mean that we never
> hit the time.sleep() below, and will put the system into a CPU spin if the
> server or session is mis-configured.
> 
> I think you need to remove these two relaunch_self() calls.  Then apply this
> logic to the case where desktop and session are both None:
> 
> If |last_launch_time| is unset (0):
>   this is a first-time launch, so go ahead and launch everything
> else:
>   sleep a bit, to avoid spinning
>   relaunch_self()
> 
> You could test this by creating an empty file at
> ~/.chrome-remote-desktop-session and see if it spins like mad :)

Good catch! Done.

[Lambros, 2012-08-20 21:26:20]

lgtm