cros: Protect app windows from out-of-memory kills

cros: Protect app windows from out-of-memory kills

Web apps that run in a window tend to be high-value and
have large visible surfaces, which makes them undesirable
to discard in out-of-memory situations.  Deprioritize them
in the same way we do pinned tabs.

Also cleaned up the OomPriorityManager unit test, which
wasn't completely testing that the priority sort actually
reordered things.

BUG=143418
TEST=Updated OomPriorityManager unit test


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=152680

[James Cook, 2012-08-17 22:20:09]

Greg, PTAL.  This is a response to the G+ thread I added you to.

[Greg Spencer (Chromium), 2012-08-21 18:51:42]

http://codereview.chromium.org/10860023/diff/1/chrome/browser/chromeos/oom_pr...
File chrome/browser/chromeos/oom_priority_manager.cc (left):

http://codereview.chromium.org/10860023/diff/1/chrome/browser/chromeos/oom_pr...
chrome/browser/chromeos/oom_priority_manager.cc:193: str +=
ASCIIToUTF16(it->sudden_termination_allowed ? " sudden_ok " : "");
Did you mean to remove the output of the sudden_termination_allowed_ flag?

Actually, it seems we don't do anything at all with that flag: can we remove it
completely?

[James Cook, 2012-08-21 19:57:08]

Please have another look. I removed the unused flag.

[Greg Spencer (Chromium), 2012-08-21 20:34:23]

lgtm

[James Cook, 2012-08-21 20:36:34]

Satoru, can I get OWNERS approval?

[satorux1, 2012-08-21 20:51:08]

LGTM. You might want to create 'memory' sub directory and put memory related
stuff there, as well as OWNERS file.

[James Cook, 2012-08-21 21:40:27]

On 2012/08/21 20:51:08, satorux1 wrote:
> LGTM. You might want to create 'memory' sub directory and put memory related
> stuff there, as well as OWNERS file.

That's a good idea.  Let's do that in another CL.

[commit-bot: I haz the power, 2012-08-21 21:41:05]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamescook@chromium.org/10860023/4001

[commit-bot: I haz the power, 2012-08-22 00:09:47]

Change committed as 152680