Disable suggest field trial in tests.

Disable suggest field trial in tests.

See bug link. The test flakiness is because of being randomly selected into a
suggest field trial that causes the Google-returned suggestion to be ranked
above the what-you-typed entry. This CL attempts to disable the suggest field
trial by forcing a specific group (which at the moment doesn't have any
experimental behaviour).

BUG=143308
R=mpearson@chromium.org,nirnimesh@chromium.org
TEST=This test should no longer flake on the bots. If it does, then it's likely
that group #10 has been selected into a field trial. The fix would be to
disable the suggest field trials properly (as mentioned in the TODO).

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=152183

[sreeram, 2012-08-17 21:22:12]

@mpearson for review, @nirnimesh for OWNERS approval

[Nirnimesh, 2012-08-17 21:58:28]

LGTM

[Mark P, 2012-08-17 22:49:31]

I assume Nimimesh reviewed the omnibox.py structure.  I haven't look at tests
that look like this before.

One comment of something to change, then
lgtm

--mark

http://codereview.chromium.org/10860022/diff/1/chrome/test/functional/omnibox.py
File chrome/test/functional/omnibox.py (right):

http://codereview.chromium.org/10860022/diff/1/chrome/test/functional/omnibox...
chrome/test/functional/omnibox.py:526: return
['--force-fieldtrials=OmniboxSearchSuggest/0/']
Please use group 10.  That will always be a control.  Sometimes we may use group
0 as an experiment.

http://codereview.chromium.org/10860022/diff/1/chrome/test/functional/omnibox...
chrome/test/functional/omnibox.py:528: def testGoogleSearch(self):
I assume you copied this function from earlier; I won't bother to review it.

[sreeram, 2012-08-17 22:57:33]

http://codereview.chromium.org/10860022/diff/1/chrome/test/functional/omnibox.py
File chrome/test/functional/omnibox.py (right):

http://codereview.chromium.org/10860022/diff/1/chrome/test/functional/omnibox...
chrome/test/functional/omnibox.py:526: return
['--force-fieldtrials=OmniboxSearchSuggest/0/']
On 2012/08/17 22:49:31, Mark P wrote:
> Please use group 10.  That will always be a control.  Sometimes we may use
group
> 0 as an experiment.

Done.

http://codereview.chromium.org/10860022/diff/1/chrome/test/functional/omnibox...
chrome/test/functional/omnibox.py:528: def testGoogleSearch(self):
On 2012/08/17 22:49:31, Mark P wrote:
> I assume you copied this function from earlier; I won't bother to review it.

Yup. I just moved the code from its earlier location. No edits to it at all.

[jennb, 2012-08-18 07:01:26]

Hi, this change is preventing pyauto tests on linux from running:
http://build.chromium.org/p/chromium.pyauto/builders/Linux%20%28deb%29/builds...

I would have fixed it for you, except I'm not sure if you intend for the
testGoogleSearch exclusion to be removed now that you've made this change or if
it simply needs a prefix update.

[Nirnimesh, 2012-08-18 08:24:02]

On 2012/08/18 07:01:26, jennb wrote:
> Hi, this change is preventing pyauto tests on linux from running:
>
http://build.chromium.org/p/chromium.pyauto/builders/Linux%2520%2528deb%2529/...
> 
> I would have fixed it for you, except I'm not sure if you intend for the
> testGoogleSearch exclusion to be removed now that you've made this change or
if
> it simply needs a prefix update.

Fixed in https://src.chromium.org/viewvc/chrome?view=rev&revision=152250
Thanks for pointing out.

[sreeram, 2012-08-19 18:37:37]

Thanks Jenn and Nirnimesh for catching and fixing the rename.