Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 10860016: Add missing NMF files. (Closed)

Created:
8 years, 4 months ago by noelallen1
Modified:
8 years, 4 months ago
Reviewers:
binji
CC:
native-client-reviews_googlegroups.com
Visibility:
Public.

Description

Add missing NMF files. NaCl configurations fail to run because the NMF files are missing. This CL adds a post link step to invoke create_nmf.py Committed: https://code.google.com/p/nativeclient-sdk/source/detail?r=1412

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -6 lines) Patch
M visual_studio/NativeClientVSAddIn/InstallerResources/examples/hello_world_gles/hello_world_gles/common.js View 1 1 chunk +2 lines, -2 lines 0 comments Download
M visual_studio/NativeClientVSAddIn/InstallerResources/examples/hello_world_gles/hello_world_gles/hello_world_gles.vcxproj View 1 4 chunks +10 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
noelallen1
8 years, 4 months ago (2012-08-17 19:49:50 UTC) #1
binji
lgtm... but, are these right? If I look at the my example .nmf files for ...
8 years, 4 months ago (2012-08-17 19:53:29 UTC) #2
binji
8 years, 4 months ago (2012-08-20 19:00:24 UTC) #3
lgtm

Powered by Google App Engine
This is Rietveld 408576698