Issue 10860004: image-skia: Remove implicit conversion to SkBitmap on linux and chromeos.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10860004: image-skia: Remove implicit conversion to SkBitmap on linux and chromeos. (Closed)

Created:
8 years, 4 months ago by sadrul

Modified:
8 years, 4 months ago

Reviewers:
sky

CC:
chromium-reviews, mihaip-chromium-reviews_chromium.org, jam, yoshiki+watch_chromium.org, dcheng, joi+watch-content_chromium.org, Aaron Boodman, rsesek+watch_chromium.org, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

image-skia: Remove implicit conversion to SkBitmap on linux and chromeos. The code for the implicit conversion is still used on windows and mac, but they will eventually be removed too. BUG=141146 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=152583

Patch Set 1 #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+34 lines, -21 lines)			Patch
M	chrome/browser/ui/gtk/extensions/extension_install_dialog_gtk.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/gtk/extensions/extension_uninstall_dialog_gtk.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/gtk/menu_gtk.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/gtk/speech_recognition_bubble_gtk.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/gtk/task_manager_gtk.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/browser/web_contents/web_contents_drag_win.cc	View	2 chunks	+8 lines, -1 line	0 comments	Download
M	ui/gfx/image/image_skia.h	View	3 chunks	+6 lines, -2 lines	0 comments	Download
M	ui/gfx/image/image_skia.cc	View	2 chunks	+12 lines, -12 lines	0 comments	Download
M	ui/gfx/image/image_skia_unittest.cc	View	2 chunks	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages