Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issue 10859002: Speech bubble: Use the images of the appropriate scale for the speech bubble. (Closed)

Created:
8 years, 4 months ago by sadrul
Modified:
8 years, 4 months ago
Reviewers:
Satish, sky
CC:
chromium-reviews, rsesek+watch_chromium.org, Satish, pkotwicz
Visibility:
Public.

Description

Speech bubble: Use the images of the appropriate scale for the speech bubble. Instead of using ImageSkia to replace the use of SkBitmap altogether, this CL makes sure that the correct SkBitmap from the ImageSkia is used. BUG=141146 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=152568

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : remove-irrelevant-test #

Patch Set 4 : implicit-on-mac-win #

Patch Set 5 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -13 lines) Patch
M chrome/browser/speech/speech_recognition_bubble.h View 3 chunks +6 lines, -2 lines 0 comments Download
M chrome/browser/speech/speech_recognition_bubble.cc View 1 4 chunks +25 lines, -11 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
sadrul
satish@, sky@ Please review. pkotwicz@ FYI
8 years, 4 months ago (2012-08-16 21:50:59 UTC) #1
sky
LGTM
8 years, 4 months ago (2012-08-16 23:04:57 UTC) #2
Satish
LGTM I presume this was tested manually by invoking speech recognition on a <input x-webkit-speech> ...
8 years, 4 months ago (2012-08-16 23:22:06 UTC) #3
sadrul
8 years, 4 months ago (2012-08-17 05:33:31 UTC) #4
On 2012/08/16 23:22:06, Satish wrote:
> LGTM
> 
> I presume this was tested manually by invoking speech recognition on a <input
> x-webkit-speech> element to verify the images in the recognition popup?

Yes :) I tested on chromeos in high-dpi. I will try more before landing.

I removed the change to remove the code for implicit ImageSkia -> SkBitmap from
this CL since it turns out there were some more places that depends on the code
on other platforms. For linux/gtk: http://codereview.chromium.org/10860004/ and
mac: http://codereview.chromium.org/10834382/

Powered by Google App Engine
This is Rietveld 408576698