Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(402)

Unified Diff: webkit/appcache/appcache_storage_impl.cc

Issue 10857073: base::Bind: Make use of IgnoreResult. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/appcache/appcache_storage_impl.cc
diff --git a/webkit/appcache/appcache_storage_impl.cc b/webkit/appcache/appcache_storage_impl.cc
index 3d8c785ca9089a15a20197bd0c0263f01113314f..89b196b9606385f5dd08dd6c68e1575d111189bc 100644
--- a/webkit/appcache/appcache_storage_impl.cc
+++ b/webkit/appcache/appcache_storage_impl.cc
@@ -44,13 +44,6 @@ static const FilePath::CharType kDiskCacheDirectoryName[] =
namespace {
-// Helper with no return value for use with base::Bind.
-// TODO(jhawkins): Figure out why base::IgnoreResult does not work for
-// file_util::Delete on Windows.
-void DeleteDirectory(const FilePath& path) {
- file_util::Delete(path, true);
-}
-
// Helpers for clearing data from the AppCacheDatabase.
bool DeleteGroupAndRelatedRecords(AppCacheDatabase* database,
int64 group_id,
@@ -1810,7 +1803,8 @@ void AppCacheStorageImpl::OnDiskCacheInitialized(int rv) {
if (!is_incognito_) {
VLOG(1) << "Deleting existing appcache data and starting over.";
db_thread_->PostTask(
- FROM_HERE, base::Bind(&DeleteDirectory, cache_directory_));
+ FROM_HERE, base::Bind(base::IgnoreResult(&file_util::Delete),
+ cache_directory_, true));
}
}
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698