Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10857071: Options: Rename options2 namespace to options. (Closed)

Created:
8 years, 4 months ago by James Hawkins
Modified:
8 years, 4 months ago
Reviewers:
csilv
CC:
chromium-reviews, groby+watch_chromium.org, nkostylev+watch_chromium.org, tfarina, oshima+watch_chromium.org, gbillock+watch_chromium.org, smckay+watch_chromium.org, stevenjb+watch_chromium.org
Visibility:
Public.

Description

Options: Rename options2 namespace to options. BUG=122251 R=csilv Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=152279

Patch Set 1 #

Total comments: 2

Patch Set 2 : Review fix. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+254 lines, -254 lines) Patch
M chrome/browser/ui/chrome_pages.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/network_screen_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/oobe_ui.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/proxy_settings_ui.h View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/proxy_settings_ui.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options2/advanced_options_utils.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options2/advanced_options_utils_mac.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options2/advanced_options_utils_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options2/advanced_options_utils_x11.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options2/autofill_options_handler.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options2/autofill_options_handler.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options2/browser_options_handler.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options2/browser_options_handler.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options2/certificate_manager_handler.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options2/certificate_manager_handler.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options2/chromeos/accounts_options_handler.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/options2/chromeos/accounts_options_handler.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options2/chromeos/bluetooth_options_handler.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/options2/chromeos/bluetooth_options_handler.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options2/chromeos/change_picture_options_handler.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/options2/chromeos/change_picture_options_handler.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options2/chromeos/core_chromeos_options_handler.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/options2/chromeos/core_chromeos_options_handler.cc View 7 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/ui/webui/options2/chromeos/cros_language_options_handler.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/options2/chromeos/cros_language_options_handler.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/options2/chromeos/display_options_handler.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/options2/chromeos/display_options_handler.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options2/chromeos/guest_mode_options_ui_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options2/chromeos/internet_options_handler.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options2/chromeos/internet_options_handler.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options2/chromeos/keyboard_handler.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/options2/chromeos/keyboard_handler.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options2/chromeos/language_chewing_handler.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/options2/chromeos/language_chewing_handler.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options2/chromeos/language_hangul_handler.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/options2/chromeos/language_hangul_handler.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options2/chromeos/language_mozc_handler.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/options2/chromeos/language_mozc_handler.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options2/chromeos/language_options_util.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options2/chromeos/language_options_util.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options2/chromeos/language_pinyin_handler.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/options2/chromeos/language_pinyin_handler.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options2/chromeos/pointer_handler.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/options2/chromeos/pointer_handler.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options2/chromeos/proxy_handler.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/options2/chromeos/proxy_handler.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options2/chromeos/set_wallpaper_options_handler.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/options2/chromeos/set_wallpaper_options_handler.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options2/chromeos/stats_options_handler.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/options2/chromeos/stats_options_handler.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options2/chromeos/timezone_options_util.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options2/chromeos/timezone_options_util.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options2/chromeos/user_image_source.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options2/chromeos/user_image_source.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options2/chromeos/wallpaper_source.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options2/chromeos/wallpaper_source.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options2/chromeos/wallpaper_thumbnail_source.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options2/chromeos/wallpaper_thumbnail_source.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options2/clear_browser_data_handler.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options2/clear_browser_data_handler.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options2/content_settings_handler.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options2/content_settings_handler.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options2/cookies_view_handler.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options2/cookies_view_handler.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options2/core_options_handler.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options2/core_options_handler.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options2/font_settings_handler.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options2/font_settings_handler.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options2/font_settings_utils.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options2/font_settings_utils_mac.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options2/font_settings_utils_win.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options2/font_settings_utils_x11.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options2/handler_options_handler.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options2/handler_options_handler.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options2/home_page_overlay_handler.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options2/home_page_overlay_handler.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options2/import_data_handler.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options2/import_data_handler.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options2/language_options_handler.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options2/language_options_handler.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options2/language_options_handler_common.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options2/language_options_handler_common.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options2/language_options_handler_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/options2/manage_profile_handler.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options2/manage_profile_handler.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options2/media_galleries_handler.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options2/media_galleries_handler.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options2/options_sync_setup_handler.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options2/options_sync_setup_handler.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options2/options_ui.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options2/options_ui.cc View 1 6 chunks +22 lines, -22 lines 0 comments Download
M chrome/browser/ui/webui/options2/options_ui_browsertest.h View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/webui/options2/options_ui_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options2/password_manager_handler.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options2/password_manager_handler.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options2/search_engine_manager_handler.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options2/search_engine_manager_handler.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options2/startup_pages_handler.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options2/startup_pages_handler.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options2/web_intents_settings_handler.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options2/web_intents_settings_handler.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/sync_promo/sync_promo_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/sync_setup_handler.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
James Hawkins
8 years, 4 months ago (2012-08-18 14:25:20 UTC) #1
csilv
lgtm http://codereview.chromium.org/10857071/diff/1/chrome/browser/ui/webui/options2/options_sync_setup_handler.cc File chrome/browser/ui/webui/options2/options_sync_setup_handler.cc (right): http://codereview.chromium.org/10857071/diff/1/chrome/browser/ui/webui/options2/options_sync_setup_handler.cc#newcode27 chrome/browser/ui/webui/options2/options_sync_setup_handler.cc:27: } // options2 options2 -> namespace options
8 years, 4 months ago (2012-08-18 20:12:53 UTC) #2
James Hawkins
8 years, 4 months ago (2012-08-19 02:49:55 UTC) #3 
http://codereview.chromium.org/10857071/diff/1/chrome/browser/ui/webui/option...
File chrome/browser/ui/webui/options2/options_sync_setup_handler.cc (right):

http://codereview.chromium.org/10857071/diff/1/chrome/browser/ui/webui/option...
chrome/browser/ui/webui/options2/options_sync_setup_handler.cc:27: }  //
options2
On 2012/08/18 20:12:53, csilv wrote:
> options2 -> namespace options

Done.

Powered by Google App Engine
This is Rietveld 408576698