Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10128)

Unified Diff: chrome/common/metrics/metrics_service_base.cc

Issue 10857067: Add comments to HistogramFlatterner interface and rename a function (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/metrics/metrics_service_base.h ('k') | content/common/child_histogram_message_filter.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/metrics/metrics_service_base.cc
===================================================================
--- chrome/common/metrics/metrics_service_base.cc (revision 151415)
+++ chrome/common/metrics/metrics_service_base.cc (working copy)
@@ -41,17 +41,19 @@
log_manager_.current_log()->RecordHistogramDelta(histogram, snapshot);
}
-void MetricsServiceBase::InconsistencyDetected(int problem) {
+void MetricsServiceBase::InconsistencyDetected(
+ Histogram::Inconsistencies problem) {
UMA_HISTOGRAM_ENUMERATION("Histogram.InconsistenciesBrowser",
problem, Histogram::NEVER_EXCEEDED_VALUE);
}
-void MetricsServiceBase::UniqueInconsistencyDetected(int problem) {
+void MetricsServiceBase::UniqueInconsistencyDetected(
+ Histogram::Inconsistencies problem) {
UMA_HISTOGRAM_ENUMERATION("Histogram.InconsistenciesBrowserUnique",
problem, Histogram::NEVER_EXCEEDED_VALUE);
}
-void MetricsServiceBase::SnapshotProblemResolved(int amount) {
+void MetricsServiceBase::InconsistencyDetectedInLoggedCount(int amount) {
UMA_HISTOGRAM_COUNTS("Histogram.InconsistentSnapshotBrowser",
std::abs(amount));
}
« no previous file with comments | « chrome/common/metrics/metrics_service_base.h ('k') | content/common/child_histogram_message_filter.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698