Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Side by Side Diff: media/filters/audio_renderer_impl.h

Issue 10857066: Don't use an unretained read callback when calling AudioDecoder::Read(). (Closed) Base URL: svn://chrome-svn/chrome/trunk/src
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Audio rendering unit utilizing an AudioRendererSink to output data. 5 // Audio rendering unit utilizing an AudioRendererSink to output data.
6 // 6 //
7 // This class lives inside three threads during it's lifetime, namely: 7 // This class lives inside three threads during it's lifetime, namely:
8 // 1. Render thread. 8 // 1. Render thread.
9 // This object is created on the render thread. 9 // This object is created on the render thread.
10 // 2. Pipeline thread 10 // 2. Pipeline thread
(...skipping 194 matching lines...) Expand 10 before | Expand all | Expand 10 after
205 // remember when it should stop playing, and do not assume that buffer is 205 // remember when it should stop playing, and do not assume that buffer is
206 // empty till that time. Workaround is not bulletproof, as we don't exactly 206 // empty till that time. Workaround is not bulletproof, as we don't exactly
207 // know when that particular data would start playing, but it is much better 207 // know when that particular data would start playing, but it is much better
208 // than nothing. 208 // than nothing.
209 base::Time earliest_end_time_; 209 base::Time earliest_end_time_;
210 210
211 AudioParameters audio_parameters_; 211 AudioParameters audio_parameters_;
212 212
213 bool underflow_disabled_; 213 bool underflow_disabled_;
214 214
215 AudioDecoder::ReadCB read_cb_;
216
217 DISALLOW_COPY_AND_ASSIGN(AudioRendererImpl); 215 DISALLOW_COPY_AND_ASSIGN(AudioRendererImpl);
218 }; 216 };
219 217
220 } // namespace media 218 } // namespace media
221 219
222 #endif // MEDIA_FILTERS_AUDIO_RENDERER_IMPL_H_ 220 #endif // MEDIA_FILTERS_AUDIO_RENDERER_IMPL_H_
OLDNEW
« no previous file with comments | « no previous file | media/filters/audio_renderer_impl.cc » ('j') | media/filters/audio_renderer_impl.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698