chrome/browser/chromeos/login/user_image.cc - Issue 10857060: Fixes UserImage::CreateAndEncode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/login/user_image.cc

Issue 10857060: Fixes UserImage::CreateAndEncode (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/chromeos/login/user_image.cc

diff --git a/chrome/browser/chromeos/login/user_image.cc b/chrome/browser/chromeos/login/user_image.cc

index 00a8ce0b53fbbfab9aca9f3fa43b48b82f396ef6..67f3d9fdc2c321091dd4e911dbc3a1ae3cd00239 100644

--- a/chrome/browser/chromeos/login/user_image.cc

+++ b/chrome/browser/chromeos/login/user_image.cc

@@ -24,7 +24,7 @@ bool IsAnimatedImage(const UserImage::RawImage& data) {

bool EncodeBGRAImageSkia(const gfx::ImageSkia& image,

bool discard_transparency,

std::vector<unsigned char>* output) {

- if (image.empty() || image.bitmap())

+ if (image.empty() || !image.bitmap())

return false;

return gfx::PNGCodec::EncodeBGRASkBitmap(*image.bitmap(),

discard_transparency, output);

« no previous file with comments | « no previous file | no next file » | no next file with comments »