Issue 10857057: [content shell] rip out code that moves windows off screen during layout tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10857057: [content shell] rip out code that moves windows off screen during layout tests (Closed)

Created:
8 years, 4 months ago by jochen (gone - plz use gerrit)

Modified:
8 years, 4 months ago

Reviewers:
jam

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[content shell] rip out code that moves windows off screen during layout tests It just makes debugging difficult BUG=111316 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=152181

Patch Set 1 #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+2 lines, -20 lines)			Patch
M	content/shell/shell_gtk.cc	View	3 chunks	+0 lines, -5 lines	0 comments	Download
M	content/shell/shell_mac.mm	View	3 chunks	+0 lines, -6 lines	0 comments	Download
M	content/shell/shell_win.cc	View	2 chunks	+2 lines, -9 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/10857057/1

8 years, 4 months ago (2012-08-17 17:10:09 UTC) #3

commit-bot: I haz the power

Try job failure for 10857057-1 on linux_rel for step "update". http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=48463 Step "update" is always ...

8 years, 4 months ago (2012-08-17 18:14:31 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/10857057/1

8 years, 4 months ago (2012-08-17 18:21:01 UTC) #5

Change committed as 152181

Expand Messages | Collapse Messages