Replaced Value by Definition in the renaming environment.

runtime/vm/flow_graph.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/flow_graph.h"
 
 #include "vm/bit_vector.h"
 #include "vm/flow_graph_builder.h"
 #include "vm/intermediate_language.h"
 #include "vm/longjump.h"
@@ skipping 245 matching lines @@
 }
 
 
 void FlowGraph::Rename(GrowableArray<PhiInstr*>* live_phis) {
   // TODO(fschneider): Support catch-entry.
   if (graph_entry_->SuccessorCount() > 1) {
     Bailout("Catch-entry support in SSA.");
   }
 
   // Initialize start environment.
-  GrowableArray<Value*> start_env(variable_count());
+  GrowableArray<Definition*> start_env(variable_count());
   for (intptr_t i = 0; i < parameter_count(); ++i) {
     ParameterInstr* param = new ParameterInstr(i);
     param->set_ssa_temp_index(alloc_ssa_temp_index());  // New SSA temp.
-    start_env.Add(new UseVal(param));
+    start_env.Add(param);
   }
 
   // All locals are initialized with #null.
-  Value* null_value = new ConstantVal(Object::ZoneHandle());
+  Definition* null_def = new BindInstr(BindInstr::kUsed,
+                                       new ConstantVal(Object::ZoneHandle()));
+  null_def->set_ssa_temp_index(alloc_ssa_temp_index());  // New SSA temp.
   while (start_env.length() < variable_count()) {
-    start_env.Add(null_value);
+    start_env.Add(null_def);
   }
   graph_entry_->set_start_env(
       new Environment(start_env, non_copied_parameter_count_));
 
   BlockEntryInstr* normal_entry = graph_entry_->SuccessorAt(0);
   ASSERT(normal_entry != NULL);  // Must have entry.
-  GrowableArray<Value*> env(variable_count());
+  GrowableArray<Definition*> env(variable_count());
   env.AddArray(start_env);
   RenameRecursive(normal_entry, &env, live_phis);
 }
 
 
-// Helper to a copy a value iff it is a UseVal.
-static Value* CopyValue(Value* value) {
-  return value->IsUse()
-      ? new UseVal(value->AsUse()->definition())
-      : value;
-}
-
-
 void FlowGraph::RenameRecursive(BlockEntryInstr* block_entry,
-                                GrowableArray<Value*>* env,
+                                GrowableArray<Definition*>* env,
                                 GrowableArray<PhiInstr*>* live_phis) {
   // 1. Process phis first.
   if (block_entry->IsJoinEntry()) {
     JoinEntryInstr* join = block_entry->AsJoinEntry();
     if (join->phis() != NULL) {
       for (intptr_t i = 0; i < join->phis()->length(); ++i) {
         PhiInstr* phi = (*join->phis())[i];
         if (phi != NULL) {
-          (*env)[i] = new UseVal(phi);
+          (*env)[i] = phi;
           phi->set_ssa_temp_index(alloc_ssa_temp_index());  // New SSA temp.
         }
       }
     }
   }
 
   // 2. Process normal instructions.
   for (ForwardInstructionIterator it(block_entry); !it.Done(); it.Advance()) {
     Instruction* current = it.Current();
     // Attach current environment to the instruction. First, each instruction
     // gets a full copy of the environment. Later we optimize this by
     // eliminating unnecessary environments.
     current->set_env(new Environment(*env, non_copied_parameter_count_));
 
     // 2a. Handle uses:
     // Update expression stack environment for each use.
     // For each use of a LoadLocal or StoreLocal: Replace it with the value
     // from the environment.
     for (intptr_t i = current->InputCount() - 1; i >= 0; --i) {
       Value* v = current->InputAt(i);
       if (!v->IsUse()) continue;
       // Update expression stack.
       ASSERT(env->length() > variable_count());
 
-      Value* input_value = env->Last();
-      ASSERT(input_value->IsUse());
+      Definition* input_defn = env->Last();
       env->RemoveLast();
 
       BindInstr* as_bind = v->AsUse()->definition()->AsBind();
       if ((as_bind != NULL) &&
           (as_bind->computation()->IsLoadLocal() ||
            as_bind->computation()->IsStoreLocal())) {
         // Assert exactly one use.
         ASSERT(as_bind->use_list() == v);
         ASSERT(as_bind->use_list()->next_use() == NULL);
         // Remove the use, its definition and copy the environment value.
         v->RemoveFromUseList();
         as_bind->RemoveFromGraph();
-        current->SetInputAt(i, CopyValue(input_value));
+        current->SetInputAt(i, new UseVal(input_defn));
       }
     }
 
     // Drop pushed arguments for calls.
     for (intptr_t j = 0; j < current->ArgumentCount(); j++) {
       env->RemoveLast();
     }
 
     // 2b. Handle LoadLocal and StoreLocal.
     // For each LoadLocal: Remove it from the graph.
     // For each StoreLocal: Remove it from the graph and update the environment.
     BindInstr* bind = current->AsBind();
     if (bind != NULL) {
       LoadLocalComp* load = bind->computation()->AsLoadLocal();
       StoreLocalComp* store = bind->computation()->AsStoreLocal();
       if ((load != NULL) || (store != NULL)) {
         intptr_t index;
         if (store != NULL) {
           index = store->local().BitIndexIn(non_copied_parameter_count_);
           // Update renaming environment.
-          (*env)[index] = store->value();
+          ASSERT(store->value()->IsUse());
+          (*env)[index] = store->value()->AsUse()->definition();
         } else {
           // The graph construction ensures we do not have an unused LoadLocal
           // computation.
           ASSERT(bind->is_used());
           index = load->local().BitIndexIn(non_copied_parameter_count_);
 
-          Value* value = (*env)[index];
-          if (value->IsUse()) {
-            PhiInstr* phi = value->AsUse()->definition()->AsPhi();
-            if ((phi != NULL) && !phi->is_alive()) {
-              phi->mark_alive();
-              live_phis->Add(phi);
-            }
+          PhiInstr* phi = (*env)[index]->AsPhi();
+          if ((phi != NULL) && !phi->is_alive()) {
+            phi->mark_alive();
+            live_phis->Add(phi);
           }
         }
         // Update expression stack or remove from graph.
         if (bind->is_used()) {
           // Assert exactly one use.
           ASSERT(bind->use_list() != NULL);
           ASSERT(bind->use_list()->next_use() == NULL);
-          env->Add(CopyValue((*env)[index]));
+          env->Add((*env)[index]);
           // We remove load/store instructions when we find their use in 2a.
         } else {
           it.RemoveCurrentFromGraph();
         }
       } else {
         // Not a load or store.
         if (bind->is_used()) {
           // Assign fresh SSA temporary and update expression stack.
           bind->set_ssa_temp_index(alloc_ssa_temp_index());
-          env->Add(new UseVal(bind));
+          env->Add(bind);
         }
       }
     }
 
     // 2c. Handle pushed argument.
     PushArgumentInstr* push = current->AsPushArgument();
     if (push != NULL) {
-      env->Add(new UseVal(push));
+      env->Add(push);
     }
   }
 
   // 3. Process dominated blocks.
   for (intptr_t i = 0; i < block_entry->dominated_blocks().length(); ++i) {
     BlockEntryInstr* block = block_entry->dominated_blocks()[i];
-    GrowableArray<Value*> new_env(env->length());
+    GrowableArray<Definition*> new_env(env->length());
     new_env.AddArray(*env);
     RenameRecursive(block, &new_env, live_phis);
   }
 
   // 4. Process successor block. We have edge-split form, so that only blocks
   // with one successor can have a join block as successor.
   if ((block_entry->last_instruction()->SuccessorCount() == 1) &&
       block_entry->last_instruction()->SuccessorAt(0)->IsJoinEntry()) {
     JoinEntryInstr* successor =
         block_entry->last_instruction()->SuccessorAt(0)->AsJoinEntry();
     intptr_t pred_index = successor->IndexOfPredecessor(block_entry);
     ASSERT(pred_index >= 0);
     if (successor->phis() != NULL) {
       for (intptr_t i = 0; i < successor->phis()->length(); ++i) {
         PhiInstr* phi = (*successor->phis())[i];
         if (phi != NULL) {
-          // Rename input operand and make a copy if it is a UseVal.
-          phi->SetInputAt(pred_index, CopyValue((*env)[i]));
+          // Rename input operand.
+          phi->SetInputAt(pred_index, new UseVal((*env)[i]));
         }
       }
     }
   }
 }
 
 
 void FlowGraph::MarkLivePhis(GrowableArray<PhiInstr*>* live_phis) {
   while (!live_phis->is_empty()) {
     PhiInstr* phi = live_phis->Last();
@@ skipping 17 matching lines @@
   intptr_t len = OS::SNPrint(NULL, 0, kFormat, function_name, reason) + 1;
   char* chars = Isolate::Current()->current_zone()->Alloc<char>(len);
   OS::SNPrint(chars, len, kFormat, function_name, reason);
   const Error& error = Error::Handle(
       LanguageError::New(String::Handle(String::New(chars))));
   Isolate::Current()->long_jump_base()->Jump(1, error);
 }
 
 
 }  // namespace dart