Import pywebsocket as third_party/pywebsocket

Import pywebsocket as third_party/pywebsocket

BUG=137639
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=152485

[Takashi Toyoshima, 2012-08-17 06:53:47]

Hi open source third party reviews team, and Mark.

As I discussed at chromium-dev thread, I'll pull another pywebsocket checkout in
chromium repository. It exists in WebKit repository as a third party tool now,
but we need it in chromium src/third_party directly by some technical reasons.

Could you check if this change correctly import pywebsocket, and follow chromium
third party policy?

Here is the thread for this.
https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-de...

Thanks.

[Mark Larson, 2012-08-18 04:27:26]

LGTM

Takashi,

Thank you, thank you, thank you for requesting review for new third-party code!

This is pulling in an external repo (code.google.com/p/pywebsocket) that I
assume has already been blessed for open source (since it has 650+ commits!). 

This is test code that we're not shipping in Chromium/Google Chrome, so
attribution to the developers is not required in the shipping product. You
correctly reflect that by putting pywebsocket in the ignore list in licenses.py.

As far as Chromium is concerned, there's no licensing issue.

I'll cc Nicolas Sylvain just to make sure that there's no additional work to set
up a mirror that the buildbots can use. Please wait for his OK before checking
in.

[nsylvain, 2012-08-20 15:45:55]

On 2012/08/18 04:27:26, Mark Larson wrote:
> LGTM
> 
> Takashi,
> 
> Thank you, thank you, thank you for requesting review for new third-party
code!
> 
> This is pulling in an external repo (code.google.com/p/pywebsocket) that I
> assume has already been blessed for open source (since it has 650+ commits!). 
> 
> This is test code that we're not shipping in Chromium/Google Chrome, so
> attribution to the developers is not required in the shipping product. You
> correctly reflect that by putting pywebsocket in the ignore list in
licenses.py.
> 
> As far as Chromium is concerned, there's no licensing issue.
> 
> I'll cc Nicolas Sylvain just to make sure that there's no additional work to
set
> up a mirror that the buildbots can use. Please wait for his OK before checking
> in.

All good on my side.

[nsylvain, 2012-08-20 15:46:54]

On 2012/08/20 15:45:55, nsylvain wrote:
> On 2012/08/18 04:27:26, Mark Larson wrote:
> > LGTM
> > 
> > Takashi,
> > 
> > Thank you, thank you, thank you for requesting review for new third-party
> code!
> > 
> > This is pulling in an external repo (code.google.com/p/pywebsocket) that I
> > assume has already been blessed for open source (since it has 650+
commits!). 
> > 
> > This is test code that we're not shipping in Chromium/Google Chrome, so
> > attribution to the developers is not required in the shipping product. You
> > correctly reflect that by putting pywebsocket in the ignore list in
> licenses.py.
> > 
> > As far as Chromium is concerned, there's no licensing issue.
> > 
> > I'll cc Nicolas Sylvain just to make sure that there's no additional work to
> set
> > up a mirror that the buildbots can use. Please wait for his OK before
checking
> > in.
> 
> All good on my side.

actually, let me run one more test.

[nsylvain, 2012-08-20 16:01:56]

On 2012/08/20 15:46:54, nsylvain wrote:
> On 2012/08/20 15:45:55, nsylvain wrote:
> > On 2012/08/18 04:27:26, Mark Larson wrote:
> > > LGTM
> > > 
> > > Takashi,
> > > 
> > > Thank you, thank you, thank you for requesting review for new third-party
> > code!
> > > 
> > > This is pulling in an external repo (code.google.com/p/pywebsocket) that I
> > > assume has already been blessed for open source (since it has 650+
> commits!). 
> > > 
> > > This is test code that we're not shipping in Chromium/Google Chrome, so
> > > attribution to the developers is not required in the shipping product. You
> > > correctly reflect that by putting pywebsocket in the ignore list in
> > licenses.py.
> > > 
> > > As far as Chromium is concerned, there's no licensing issue.
> > > 
> > > I'll cc Nicolas Sylvain just to make sure that there's no additional work
to
> > set
> > > up a mirror that the buildbots can use. Please wait for his OK before
> checking
> > > in.
> > 
> > All good on my side.
> 
> actually, let me run one more test.
It's actually still syncing, I'll ping when everything is synced properly.
Thanks

[Daniel Berlin, 2012-08-20 16:02:25]

lgtm

[nsylvain, 2012-08-20 17:47:38]

On 2012/08/20 16:02:25, Daniel Berlin wrote:
> lgtm

Ok, now it's good to go.  All mirrors are fully synced (main svn, golo mirrors,
cloud compute mirror, git mirrors)

[commit-bot: I haz the power, 2012-08-21 00:09:44]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/toyoshim@chromium.org/10857052/1

[commit-bot: I haz the power, 2012-08-21 02:27:45]

Change committed as 152485