Issue 10857050: Revert 151904 (speculative, possibly broke

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10857050: Revert 151904 (speculative, possibly broke (Closed)

Created:
8 years, 4 months ago by Nico

Modified:
8 years, 4 months ago

Reviewers:
kkania

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Revert 151904 (speculative, possibly broke login_CryptohomeIncognitoUnmounted on ChromiumOS (amd64) ) - [ChromeDriver] Disable some unnecessary chrome services at startup. These services make background network requests and aren't needed for website testing. BUG=none TEST=none NOTRY=true Review URL: https://chromiumcodereview.appspot.com/10837271 TBR=kkania@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=152037

Patch Set 1 #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -7 lines)			Patch
	M	chrome/test/webdriver/test/chromedriver_tests.py	View		1 chunk	+0 lines, -1 line	0 comments	Download
	M	chrome/test/webdriver/webdriver_automation.cc	View		2 chunks	+1 line, -6 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

kkania

On 2012/08/17 04:29:32, Nico wrote: Hey Nico, did you find this resolved the test failure?

8 years, 4 months ago (2012-08-17 16:23:46 UTC) #2

Nico

No, it looks like the bot is still red, so this revert can be reverted. ...

8 years, 4 months ago (2012-08-17 16:24:50 UTC) #3

Nico

8 years, 4 months ago (2012-08-17 16:26:36 UTC) #4

On Fri, Aug 17, 2012 at 9:24 AM, Nico Weber <thakis@chromium.org> wrote:
> No, it looks like the bot is still red, so this revert can be
> reverted. I'll do so now.

r152090

>
> On Fri, Aug 17, 2012 at 9:23 AM,  <kkania@chromium.org> wrote:
>> On 2012/08/17 04:29:32, Nico wrote:
>>
>> Hey Nico, did you find this resolved the test failure?
>>
>> https://chromiumcodereview.appspot.com/10857050/

Expand Messages | Collapse Messages