Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 10857032: (GTK only) Display an info bar after changing a site permissions and closing the Website Settings U… (Closed)

Created:
8 years, 4 months ago by markusheintz_
Modified:
8 years, 4 months ago
Reviewers:
Elliot Glaysher
CC:
chromium-reviews
Visibility:
Public.

Description

(GTK only) When a user closes the Website Setting UI after changing at least one permission setting, then display an info bar that asks the user to reload the website on order the apply the changed setting. BUG=140450 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151948

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M chrome/browser/ui/gtk/website_settings_popup_gtk.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
markusheintz_
Elliot please review this tiny one liner. Thanks a lot.
8 years, 4 months ago (2012-08-16 12:11:32 UTC) #1
Elliot Glaysher
On 2012/08/16 12:11:32, markusheintz_ wrote: > Elliot please review this tiny one liner. Thanks a ...
8 years, 4 months ago (2012-08-16 16:38:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/markusheintz@chromium.org/10857032/1
8 years, 4 months ago (2012-08-16 16:55:16 UTC) #3
commit-bot: I haz the power
8 years, 4 months ago (2012-08-16 19:40:45 UTC) #4
Change committed as 151948

Powered by Google App Engine
This is Rietveld 408576698